Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Draw every tab row rule at the content edge

973fb80906d6a1ec79ecd6b449e2e51e9cfb77d5 · Keenan Nemetz · 1d ago · parent e189a23e

Draw every tab row rule at the content edge

The strip of tabs pulls itself 10px left so the first label's text sits on
the content edge, but Settings and Admin put the row's border on that same
element, so their rule hung 10px past the repository header's. The rule now
belongs to a wrapper in every case: the repository header already had one,
and a page's tabs and a change's sections wrap the same strip in .tabrow.
The change sections also stop carrying their own copy of the tab styles,
which differed by a pixel of padding and a point of icon size.

server/settings_test.go +1−1

@@ -335,7 +335,7 @@ func TestSettingsTabsFollowTheViewersRole(t *testing.T) {
335 335 if resp.StatusCode != 200 || !strings.Contains(body, `id="secrets"`) {
336 336 t.Fatalf("maintainer settings = %d:\n%s", resp.StatusCode, body)
337 337 }
338 if strings.Contains(body, `class="tabs page-tabs"`) {
338 if strings.Contains(body, `class="tabrow"`) {
339 339 t.Fatalf("a one-tab page drew a tab row:\n%s", body)
340 340 }
341 341