Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.
vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

#23

A merged CR shows no changes

closed · opened by keenan 13d ago

keenan opened this 13d ago

The file changes tab of a merged CR is empty but should show the files that were changed.

Comments (1)

keenan 13d ago

Opened change request #01M5XM4H99DZ71VTJC8YWYS1CC for this.

Root cause: the Files tab diffs base...head. Once the request lands, the head is in the base, so the merge base is the head and the diff is empty.

Plan: the landing mark records merged_base (the base tip the merge started from) in the same commit as merged_head, and the Files tab diffs that against what landed. Records written before the field existed fall back to the merge commit’s first parent, or show nothing when a fast-forward’s starting point is no longer recoverable. The request page also keeps the file count and review link for merged requests.