Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.
vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

#145

P2: Let code and diff cards grow to their full height

closed · opened by keenan 8d ago

keenan opened this 8d ago

Why

The code browser’s source card is capped at 76vh (and at calc(100vh - 240px) inside the pane), so a file that does not fit scrolls inside the card. A diff card is not height-capped, but overflow: hidden still makes it a scroll container for the browser’s find bar.

A reviewer who presses Ctrl+F for a symbol gets a match inside an inner scroll area: the page stays where it is, only the card moves, and the result is easy to lose. The source and diff cards should grow to their content’s full height so the page is the only scroll area.

Scope

  • Remove the height cap from .blob in server/web/static/vole.css, including the .code-main .blob override and the mobile reset.
  • Keep horizontal scrolling: a line wider than the pane still scrolls sideways rather than widening the page.
  • Let .diff clip its rounded corners without being a scroll container (overflow: clip).
  • Leave the file and changed-file trees capped and sticky. They are navigation beside the pane, not the rendered source or diff; removing the cap would make a large tree push the content off the page.

Acceptance criteria

  • A long file in the code browser renders at its full height; the page scrolls, not the card.
  • A long diff in the commit view, the compare view and a change’s Files tab renders at full height with no scrollbar inside the card.
  • Ctrl+F reveals a match anywhere in the source or diff by scrolling the page, and the card keeps its rounded corners.
  • The file tree stays pinned beside the pane while the page scrolls.

Related

  • #144 reviews one file’s diff at a time, which makes the full-height diff card the common case rather than a large comparison.

Comments (0)

No comments yet.