Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Remove the avatars and read people by name again

28b19c7433fa6f6fe1ce826c443870385d856eb8 · Keenan Nemetz · 7d ago · parent 0fbeca85

Remove the avatars and read people by name again

The marks were harder to read than the names they replaced, so they are
gone: the account menu is back to the user icon, and the issue and
change tables, the profile, the directory and the contributor list all
say the account name.

This takes out everything that existed to draw a mark: the DiceBear
bundle and its licence file, the entry source that built it, the
Landscape style, avatar.go and its tests, the avatar template and its
three helper functions, the avatar palette in everforest.css and the
illustration rules in vole.css, and the app.js block that rendered and
re-rendered them on a theme change.

The tables keep the layout from the previous change — an author column
and an assignee column — because that part reads better with names too.
The assignee cells are the @name chips that already linked to the
filtered list.

`vole workflow run verify` passes, and the licence inventory is back to
one entry fewer.

server/web/templates/requests.html +1−3

@@ -49,7 +49,7 @@
49 49 <div class="row-meta"><span class="sha">{{num .Number}}</span><span>{{.CommentCount}} comment(s)</span></div>
50 50 </td>
51 51 <td><code>{{.Base}}</code> <span class="muted">←</span> {{if .HeadRef}}<code title="the branch this request follows">{{.HeadRef}}</code> {{end}}<span class="sha">{{short .Head}}</span></td>
52 <td class="nowrap">{{template "avatar" (avataronly (user .Author))}}</td>
52 <td class="muted nowrap">{{template "userlink" (user .Author)}}</td>
53 53 <td class="muted">{{.Current}}/{{$.Required}}</td>
54 54 <td class="muted nowrap">{{since .Created.Unix}}</td>
55 55 </tr>
@@ -209,7 +209,6 @@
209 209 <ul class="approval-list">
210 210 {{range .Approvals}}
211 211 <li>
212 {{template "avatar" (useravatar (user .Name))}}
213 212 <span class="cname">{{.Name}}</span>
214 213 <span class="muted">{{if .Counts}}current{{else if .Current}}no longer counts{{else}}stale{{end}}</span>
215 214 </li>
@@ -439,7 +438,6 @@
439 438 <article class="comment">
440 439 <header class="comment-head">
441 440 {{$u := user .Request.Author}}
442 {{template "avatar" (useravatar $u)}}
443 441 <span class="comment-author">{{template "userlink" $u}}</span>
444 442 <span class="muted">opened this {{since .Request.Created.Unix}}</span>
445 443 </header>