Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Read what a page needs once per request

5d440e37f16d06790ce87e2f8b7dcc7d9bf0532c · Keenan Nemetz · 10d ago · parent 34cbc99f

Read what a page needs once per request

A page and its header are built from the same facts, and each of them was
read separately: the repository (twice, each resolving HEAD's branch with
a git call), the open change requests (once for the header's count, once
for the page), and a change request looked up by reading every request.
On a repository with 30 change requests the overview paid 21 git
invocations after the metadata batching, and the requests list still paid
8.

Give each read request one memo, installed by the middleware, and have the
handlers and the header read through it. It lasts one request and covers
reads only: a request that writes metadata gets no memo, so there is no
TTL, no cross-request cache, and no invalidation protocol, and a push is
still visible on the next page load.

The header now takes the page it is rendering (`nav .Page "issues"`)
instead of six fields the view already carries, which is also why the memo
can reach it at all. Templates are unchanged in what they output.

server/web/comment_writes.go +2−2

@@ -111,7 +111,7 @@ func (w *Web) issueTopic(rw http.ResponseWriter, r *http.Request, m *repo.Meta)
111 111 // discussion. Unlike an issue, a comment here may be anchored to a diff line.
112 112 func (w *Web) requestTopic(rw http.ResponseWriter, r *http.Request, m *repo.Meta) (*commentTopic, bool) {
113 113 id := r.PathValue("id")
114 req, err := metadata.GetRequest(m.Git(), id)
114 req, err := w.requestAt(memoOf(r), m, id)
115 115 if err != nil {
116 116 w.notFound(rw, r)
117 117 return nil, false
@@ -164,7 +164,7 @@ func (w *Web) requestTopic(rw http.ResponseWriter, r *http.Request, m *repo.Meta
164 164 return "comment_thread", w.requestThread(r, m, req, t.target, msg)
165 165 }
166 166 t.reload = func() (string, any) {
167 updated, err := metadata.GetRequest(m.Git(), id)
167 updated, err := w.requestAt(memoOf(r), m, id)
168 168 if err != nil {
169 169 return "comment_thread", w.requestThread(r, m, req, nil,
170 170 "the comment was saved, but the discussion could not be re-read: "+err.Error())