Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Show both target commit ids in the review labels

6db4cdbd38e9f87e3f89c437cf2061c1fe5d3150 · Keenan Nemetz · 11d ago · parent b74cb029

Show both target commit ids in the review labels

The Head branch label names the commit under review, and Base branch names the current tip of the base. The base id is derived because the request stores only the branch name and the approval binds to that name plus the head.

server/auth_test.go +6

@@ -515,6 +515,12 @@ func TestContributorRepointsRequestTarget(t *testing.T) {
515 515 if !strings.Contains(body, `action="/r/`+f.repo+`/requests/`+id+`/target"`) || !strings.Contains(body, headRef) {
516 516 t.Fatalf("the request page does not offer the target control:\n%s", body)
517 517 }
518 // Both branch labels carry a commit link: the head under review and the
519 // current tip of the base, which is derived rather than stored.
520 if !strings.Contains(body, `title="commit under review"`) ||
521 !strings.Contains(body, `title="current tip of main"`) {
522 t.Fatalf("the target control does not show both commit ids:\n%s", body)
523 }
518 524
519 525 resp, body = f.browserPost(t, "/r/"+f.repo+"/requests/"+id+"/target", cookie, url.Values{
520 526 "csrf": {sess.CSRF}, "base": {"main"}, "head": {headRef},