vole
Clone
Read only, no credentials:
https://rodent.software/git/vole.git
Write over SSH with a registered key:
git clone ssh://git@0.0.0.0:2222/vole.git
A free and open-source forge that lives in your Git repo.
Phase 3: a change request can be discussed
7c6e52e75f3a33be57a81663bc840edd6e14f7f9 · Keenan Nemetz · 17d ago · parent 3c5d11fa
Phase 3: a change request can be discussed Until now the only ways to say something about a request were editing its body or approving it. A review thread is now a pushed file like everything else: requests/<ulid>/comments/<ulid>.md author + created, then the body It is the *same file shape* as a comment on an issue and is read and written by the same code (`issues.ParseComment`, `issues.RenderComment`, with `requests.Comment` as an alias), so the thread inherited the validation, the markdown boundary and the ownership rule instead of reimplementing them. That last one is the part worth having: `pre-receive` compares the author on the old blob to the pushing account, so a review comment is its author's to edit or delete, an admin may repair a thread (audited), and rewriting the author line in the same push does not launder it. `vole request comment <id> -m` prints the comment's id and the page anchor (`#c-<ulid>`), `edit-comment` and `rm-comment` are the author's own words, and `request show` prints the thread so the ids are discoverable at all — an id nobody can see is an id nobody can use. Adding a comment is free, like adding one to an issue: a new file's author is a claim, and the boundary has never pretended otherwise. The request's own file stays outside the ownership rule, for the reason an issue's does: state, head and base are shared, and updating them is the author's normal edit. Verified: TestParseReadsTheDiscussion (a thread plus an approval in one tree, ordered by id), TestCommentNeedsAnAuthorAndATime and TestUnknownFileInARequestIsRefused (the subtree stays a closed format, with both expected shapes named), TestCommentPaths (a request comment is not an issue comment and not an approval); and end to end through the binary, TestRequestDiscussionIsPushedAndOwned — the empty state prints the command, the CLI adds a comment, the page renders it with its anchor and `request show` lists it, a writer is refused rewriting, adopting and deleting somebody else's comment, may join the thread and may edit his own — with the issue-comment empty state assertion added to TestIssuePushedThenRendered earlier. scripts/ci.sh green (gofmt, vet, build, markdown links, go test -race ./...).
internal/issues/issues.go +5−4
| @@ -164,7 +164,7 @@ func Parse(contents map[string]string) ([]*Issue, error) { | |||
| 164 | 164 | case m[2] == issueName: | |
| 165 | 165 | applyIssue(iss, contents[path], path, &problems) | |
| 166 | 166 | case m[3] != "": | |
| 167 | c, prob := parseComment(m[3], contents[path], path) | ||
| 167 | c, prob := ParseComment(m[3], contents[path], path) | ||
| 168 | 168 | if prob != "" { | |
| 169 | 169 | problems = append(problems, prob) | |
| 170 | 170 | continue | |
| @@ -258,9 +258,10 @@ func applyIssue(iss *Issue, raw, path string, problems *[]string) { | |||
| 258 | 258 | sort.Strings(iss.Assignees) | |
| 259 | 259 | } | |
| 260 | 260 | ||
| 261 | // parseComment reads the frontmatter block a comment carries. Comments share the | ||
| 262 | // issue format so the whole branch has one reader. | ||
| 263 | func parseComment(id, raw, path string) (Comment, string) { | ||
| 261 | // ParseComment reads the frontmatter block a comment carries. A comment on a | ||
| 262 | // change request has the same shape as a comment on an issue, so this is the one | ||
| 263 | // reader for both: `requests` aliases Comment and calls this. | ||
| 264 | func ParseComment(id, raw, path string) (Comment, string) { | ||
| 264 | 265 | c := Comment{ID: id} | |
| 265 | 266 | head, body, err := frontmatter.Split([]byte(raw)) | |
| 266 | 267 | if err != nil { | |