Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.
vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Edit issue and change details in place

802e0e52533746522b3e65b953e5cc0141aa70b9 · Keenan Nemetz · 5d ago · parent 90f1ab59 

Edit issue and change details in place

Put the title pencil beside the heading and the description menu on its card, matching the comment editor. Each control saves only its own field: the title response is the heading and the description response is the card, so an open draft in the other field is not replaced. The standalone /edit page stays as the fallback.

Prefilled edit fields size themselves to their content and remain vertically resizable. Prose copied from a menu is query-escaped in the attribute, so untrusted markdown in an issue or comment cannot appear verbatim in the page.

server/web/templates/issues.html +58−20

@@ -141,44 +141,82 @@
141 141 </section>
142 142 {{end}}
143 143
144 {{define "issue"}}
145 {{template "header" .}}
146 {{template "repohead" (nav .Page "issues")}}
147
148 <div class="page-head">
144 {{define "issue_head"}}
145 <div class="page-head" id="issue-head">
149 146 <div class="page-head-main">
150 <h1><span class="page-num">{{num .Number}}</span>{{.Issue.Title}}</h1>
147 <div class="details-title">
148 <span class="page-num">{{num .Number}}</span>
149 <h1 class="details-title-view" data-details-title-view{{if .Details.Title.Active}} hidden{{end}}>{{.Issue.Title}}</h1>
150 {{if .CanEdit}}
151 <a class="title-edit-toggle" href="/r/{{.Name}}/issues/{{.Issue.ID}}/edit" data-title-edit{{if .Details.Title.Active}} hidden{{end}} aria-label="Edit title" title="Edit title">{{icon "pencil"}}</a>
152 <form class="title-edit-form" data-title-edit-form method="post" action="/r/{{.Name}}/issues/{{.Issue.ID}}/edit" hx-post="/r/{{.Name}}/issues/{{.Issue.ID}}/edit" hx-target="#issue-head" hx-swap="outerHTML" hx-disabled-elt="find button[type='submit']"{{if not .Details.Title.Active}} hidden{{end}}>
153 <input type="hidden" name="csrf" value="{{.CSRF}}">
154 <input type="hidden" name="field" value="title">
155 <input class="details-title-input" type="text" name="title" required maxlength="200" aria-label="Title" value="{{if .Details.Title.Active}}{{.Details.Title.Value}}{{else}}{{.Issue.Title}}{{end}}" data-title-edit-input{{if .Details.Title.Active}} autofocus{{end}}>
156 <button class="secondary" type="button" data-title-edit-cancel>Cancel</button>
157 <button type="submit">{{icon "check"}}Save</button>
158 </form>
159 {{end}}
160 </div>
161 {{if .Details.Title.Error}}<p class="error">{{.Details.Title.Error}}</p>{{end}}
151 162 <p class="page-sub">
152 163 <span class="state {{.Issue.State}}">{{.Issue.State}}</span>
153 164 · opened by {{template "userlink" (user .Issue.Author)}} {{since .Issue.Created.Unix}}
154 165 </p>
155 166 </div>
156 {{if or .CanEdit .CanClose}}
167 {{if .CanClose}}
157 168 <div class="page-head-actions">
158 {{if .CanEdit}}<a class="button secondary" href="/r/{{.Name}}/issues/{{.Issue.ID}}/edit">{{icon "pencil"}}Edit</a>{{end}}
159 {{if .CanClose}}
160 169 <form method="post" action="/r/{{.Name}}/issues/{{.Issue.ID}}/state">
161 170 <input type="hidden" name="csrf" value="{{.CSRF}}">
162 171 <input type="hidden" name="state" value="{{if eq .Issue.State "open"}}closed{{else}}open{{end}}">
163 172 <button class="{{if eq .Issue.State "open"}}danger{{else}}secondary{{end}}" type="submit">{{if eq .Issue.State "open"}}{{icon "circle-x"}}Close{{else}}{{icon "rotate-ccw"}}Reopen{{end}}</button>
164 173 </form>
165 {{end}}
166 174 </div>
167 175 {{end}}
168 176 </div>
177 {{end}}
178
179 {{define "issue_description"}}
180 <article class="comment{{if .Details.Description.Active}} editing{{end}}" id="issue-description">
181 <header class="comment-head">
182 {{$u := user .Issue.Author}}
183 <span class="comment-author">{{template "userlink" $u}}</span>
184 <span class="muted">opened this {{since .Issue.Created.Unix}}</span>
185 <div class="comment-menu" data-comment-menu>
186 <button type="button" class="comment-menu-toggle" data-comment-menu-toggle aria-haspopup="menu" aria-expanded="false" aria-label="Description actions">&#8943;</button>
187 <div class="comment-menu-list" data-comment-menu-list role="menu" hidden>
188 <button type="button" role="menuitem" data-copy-query="{{urlquery .Issue.Description}}">Copy text</button>
189 {{if .CanEdit}}<button type="button" role="menuitem" data-comment-edit>Edit</button>{{end}}
190 </div>
191 </div>
192 </header>
193 <div class="comment-body md">
194 {{if .Description}}{{.Description}}{{else}}<p class="muted">No description.</p>{{end}}
195 </div>
196 {{if .CanEdit}}
197 <form class="comment-edit-form details-edit-form" data-comment-edit-form method="post" action="/r/{{.Name}}/issues/{{.Issue.ID}}/edit" hx-post="/r/{{.Name}}/issues/{{.Issue.ID}}/edit" hx-target="#issue-description" hx-swap="outerHTML" hx-disabled-elt="find button[type='submit']"{{if not .Details.Description.Active}} hidden{{end}}>
198 <input type="hidden" name="csrf" value="{{.CSRF}}">
199 <input type="hidden" name="field" value="body">
200 {{if .Details.Description.Error}}<p class="error">{{.Details.Description.Error}}</p>{{end}}
201 <textarea name="body" data-autosize aria-label="Description">{{if .Details.Description.Active}}{{.Details.Description.Value}}{{else}}{{.Issue.Description}}{{end}}</textarea>
202 <div class="form-actions">
203 <button class="secondary" type="button" data-comment-edit-cancel>Cancel</button>
204 <button type="submit">{{icon "check"}}Save</button>
205 </div>
206 </form>
207 {{end}}
208 </article>
209 {{end}}
210
211 {{define "issue"}}
212 {{template "header" .}}
213 {{template "repohead" (nav .Page "issues")}}
214
215 {{template "issue_head" .}}
169 216
170 217 <div class="thread">
171 218 <div class="thread-main">
172 <article class="comment">
173 <header class="comment-head">
174 {{$u := user .Issue.Author}}
175 <span class="comment-author">{{template "userlink" $u}}</span>
176 <span class="muted">opened this {{since .Issue.Created.Unix}}</span>
177 </header>
178 <div class="comment-body md">
179 {{if .Description}}{{.Description}}{{else}}<p class="muted">No description.</p>{{end}}
180 </div>
181 </article>
219 {{template "issue_description" .}}
182 220
183 221 {{template "comment_thread" .Thread}}
184 222