Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Show the branch a change follows, not the commit it points at

b6af0843a469496912df6f8be441676fd55b38d5 · Keenan Nemetz · 4d ago · parent b7afc6a9

Show the branch a change follows, not the commit it points at

A request follows its head branch: every accepted push moves head: to the
branch tip, so the short commit printed beside the branch repeated the same
fact. The Head column now names the branch, and the commit appears only for a
pinned request, which has no branch to speak for it.

server/issues_changes_test.go +4−1

@@ -1515,6 +1515,7 @@ func TestChangeListShowsOneStatus(t *testing.T) {
1515 1515 const approvedID = "01M5JR2JK29KKMAA1T9MDNTR03"
1516 1516 const mergedID = "01M5JR2JK29KKMAA1T9MDNTR04"
1517 1517 const closedID = "01M5JR2JK29KKMAA1T9MDNTR05"
1518 const followingID = "01M5JR2JK29KKMAA1T9MDNTR06"
1518 1519 meta := f.newMetaRepo(t)
1519 1520 if err := meta.apply(map[string]string{
1520 1521 "requests/" + reviewID + "/request.md": requestFileTitled("Needs a review", "main", firstHead, "keenan", "body\n"),
@@ -1522,6 +1523,7 @@ func TestChangeListShowsOneStatus(t *testing.T) {
1522 1523 "requests/" + approvedID + "/approvals/" + f.accountName("keenan") + ".md": approvalFile("main", secondHead),
1523 1524 "requests/" + mergedID + "/request.md": requestFileMerged("Landed change", "main", secondHead, "wilbur", "keenan", nil),
1524 1525 "requests/" + closedID + "/request.md": requestFileState("Dropped change", "main", firstHead, "wilbur", "closed", "body\n"),
1526 "requests/" + followingID + "/request.md": requestFileFollowing("Follows a branch", "main", firstHead, "feature-one", "keenan", "body\n"),
1525 1527 }, "changes"); err != nil {
1526 1528 t.Fatalf("changes push: %v", err)
1527 1529 }
@@ -1533,7 +1535,8 @@ func TestChangeListShowsOneStatus(t *testing.T) {
1533 1535 for _, want := range []string{
1534 1536 "<th>Change</th><th>Status</th><th>Base</th><th>Head</th><th>Updated</th>",
1535 1537 `<code>main</code>`,
1536 `<span class="sha" title="the commit under review">`,
1538 `pinned to</span> <span class="sha"`,
1539 `title="the branch this request follows">feature-one</code>`,
1537 1540 `class="change-status review"`,
1538 1541 `title="0 of 1 required approvals."`,
1539 1542 "Waiting for review",