Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Make change requests follow branches and allow base retargeting

e050e14a64f6f19c1b1478c4c073d690ef3d3129 · Keenan Nemetz · 13d ago · parent 59464445

Make change requests follow branches and allow base retargeting

A request opened from a branch now follows it: post-receive moves the
request's head to the new tip after an accepted push, so approvals and
checks that named the old tip stop counting. Approvals stay bound to an
exact base and commit; the approval writers now require the base and head
the approver saw, so a push or retarget cannot silently approve a target
nobody reviewed. Merged requests freeze the reviewed head.

Add `vole change update --base` and a Change base control for stacked
requests. A new base changes the diff and therefore invalidates approvals,
which is what retargeting an upper request after its lower branch lands
needs. Base names may now contain slashes.

Also fix a second-boundary flake in the landing test.

server/issues_changes_test.go +5−1

@@ -380,8 +380,12 @@ func TestRequestSidebarAndDiscussionUpdateWithHtmx(t *testing.T) {
380 380
381 381 // A maintainer approves; the sidebar comes back with the approval and progress.
382 382 writerSess, writerCookie := f.browserSession(t, f.writerID)
383 request, err := metadata.GetRequest(mustRepo(t, f).Git(), id)
384 if err != nil {
385 t.Fatal(err)
386 }
383 387 resp, body = f.htmxPost(t, "/r/"+f.repo+"/requests/"+id+"/approve", writerCookie, url.Values{
384 "csrf": {writerSess.CSRF},
388 "csrf": {writerSess.CSRF}, "base": {request.Base}, "head": {request.Head},
385 389 })
386 390 if resp.StatusCode != http.StatusOK || !strings.Contains(body, `id="request-sidebar"`) ||
387 391 !strings.Contains(body, "1 of 1 required approval(s).") {