Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

#66

Make the change request sidebar compact and live

merged · by keenan 11d ago · merged into main at f2360c20 by keenan 11d ago

keenan opened this 11d ago

The side details on a change request were mostly explanatory prose, and the Checks block used a different shape from the recent runs on the repository overview. The panel also went stale: approvals, checks, and landing facts only appeared after a manual reload.

This change:

  • Moves the Review, Approvals, and Checks explanations into ? tooltips beside the section headings. The tooltip text is also the accessible name, and opens on hover, click, or keyboard focus.
  • Keeps only state in each section: the current head and branch note under Review, the approval count and list under Approvals, and the run rows under Checks. “0 of 0 required approval(s)” becomes “No approvals required.”
  • Renders checks with the overview’s compact run rows: status and job, then workflow, duration, and age. “View runs” moves into the heading as the all link.
  • Adds a polling GET /r/{name}/requests/{id}/aside fragment and refreshes the whole aside every 20 seconds. Polling pauses while the tab is hidden or focus is inside the aside, so a branch selection in progress is not replaced.
  • Uses the same aside fragment on the Runs tab so both pages share the live sidebar and landing block.

Verification: ./vole workflow check and ./vole workflow run verify both pass (format, vet, build, govulncheck, packaging, markdown links, and the test suite). The HTMX test now also covers the aside fragment and its refresh attributes.

Discussion (7)

keenan 11d ago

Follow-up pushed in 19fc6ed: file counts now live in their own Changes section with a right-aligned View changes button. The Files tab and its tree header are renamed Changes, and What would land now renders only when there is a merge fact or a closes link to report.

keenan 11d ago

37cc16c: View changes is now the same compact section action link as View runs, not a button.

keenan 11d ago

d69be4d: status action buttons (Approve, Merge, Allow CI, Close, destructive settings actions) are now filled like the primary button rather than outlined. A status-fg token uses the page ground colour for the label so contrast holds in each theme.

keenan 11d ago

b74cb02: the Review target is now two stacked, labelled fields (Base branch and Head branch), with the current head SHA and Update action on the row below. Long branch names get the full sidebar width.

keenan 11d ago

59c0625: dropped the derived base SHA and moved the head SHA to the right of the Review heading, matching the View runs and View changes action links. The target form and summary no longer repeat it.

keenan 11d ago

ad4d934: merged What would land into Review. Review now holds the head SHA, merge-clean/conflict state, closes links, and the target controls; Changes follows it, then Approvals and Checks. Write fragments compute the landing facts too, so the sidebar stays complete.

keenan 11d ago

Tightened the vertical gap between the Base branch and Head branch selects from 8px to 4px.