Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.
vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

#175

Remove the merge confetti and canvas-confetti

merged · by keenan 6d ago · merged into main at 8032d15a by keenan 6d ago

keenan opened this 6d ago

Why

Landing a change ended with a burst of confetti drawn from a vendored copy of canvas-confetti. The celebration was the only consumer of that library, its license file, and the ?merged=1 flag the landing redirect carried so a reload would not replay it. The request page already shows the result: the change is merged, with the commit it landed as.

Removing it drops roughly 900 lines of vendored JavaScript and one more asset to keep licensed and patched.

What changed

  • Delete server/web/static/confetti.browser.js and server/web/static/canvas-confetti.LICENSE.
  • Remove the loader and burst from app.js, and the test that guarded it.
  • Remove the library from NOTICE and the static-asset comments.
  • Stop adding ?merged=1 after a landing. The redirect now goes to the plain request page.

The separate ?merging=1 flag for merge-when-ready is unchanged.

Verification

  • go test -tags sqlite_fts5 ./server -run 'TestLandingRedirectsToTheRequestPage|TestStatic'
  • python3 asset check against NOTICE reports no findings
  • ./vole workflow check

Discussion (0)

No discussion yet.