Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.
vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Do not build a job the combined result already passed for the branch

5f6163bb4051955a403b998d48f6dfabd3d6939a · Keenan Nemetz · 7h ago · parent c4ad0d5a 

Do not build a job the combined result already passed for the branch

A landing lands the commit the combined result published: same tree, same
workflow, same job, already run for the base branch before it landed. The push
that moves the branch then queued all of it again, so one commit showed up twice
in the run list and the runner did the same work twice.

Queueing now asks whether a combined result for this branch already ran and passed
this job at this commit. If it did, the push owes nothing and the run that tested
the landing stays the one run for it. The question is one indexed query
(runs_repo_sha), asked only for a push to the branch itself: a tag is a release
build of its own, an event run is a new occurrence of one, and the candidate's own
run is the one being reused.

A job that deploys the site is the exception. A combined result never deploys — it
is not on the branch yet — so publishing the site is work it did not do, and that
run still happens. Repositories without a pages job, which is most of them, see the
duplicate disappear entirely.

Not in this change: a fast-forward landing still builds the head on the base branch
after the head's own branch built it. Those runs select workflows by branch, so they
are not the same work by construction; only the combined result is queued as "a
normal run for the base branch", which is what makes this dedupe exact.

Closes 01M6Z0MXZNRCEDD6HBKCJE4WCR

docs/change-requests.md +7−1

@@ -197,7 +197,13 @@ queued.
197 197
198 198 The combined result uses the workflow files at the merge, so a workflow change on
199 199 the base applies to the landing. It is a normal run for the base branch, but it does
200 not deploy the repository's site. A combined result derived from a contributor
200 not deploy the repository's site.
201
202 A landing lands that same commit, so the push that moves the branch does not run
203 those jobs a second time: the tree, the workflow and the job already ran for this
204 branch, and the run list shows the run that tested it once. A job that deploys the
205 site is the exception — a combined result never deploys — so that one still runs on
206 the branch, because publishing the site is work the combined result did not do. A combined result derived from a contributor
201 207 branch is still untrusted code: it runs only after that exact head was allowed, and
202 208 it uses the contributor's cache namespace.
203 209