vole
Clone
Read only, no credentials:
https://rodent.software/vole.git
Write over SSH with a registered key:
git clone ssh://git@rodent.software:2222/vole.git
A free and open-source forge that lives in your Git repo.
Phase 5: an object is served only through a repository that holds it
65b88b3b1940623b6f7fbc686b19e986497c9ff2 · Keenan Nemetz · 17d ago · parent bf1e027c
Phase 5: an object is served only through a repository that holds it The store was instance-wide and content-addressed, so an object was fetchable through any repository whose read rule you passed, provided you knew its sha256. That is now impossible, and the fix is structural rather than a check: the pool still holds the bytes once, and each repository has a hard link into a namespace of its own (data/lfs/repos/<repo>/…). A fetch reads only that namespace, so "which repository owns these bytes" stops being a database question that can go stale and becomes a fact about the filesystem — and gc reconciles the links from the refs, which keeps the promise that derived state can always be thrown away and rebuilt. The alternatives were worse. A (repo, oid) table would have made the read path depend on the index, so deleting data/index.db — which the roadmap promises loses nothing — would have stopped LFS fetches until a rebuild. Namespacing the storage itself would have cost the deduplication the store exists for. Hard links give both: one copy of the bytes, one directory entry per repository, and removing one repository's link leaves the other's data alone. Three consequences that had to be handled rather than assumed: - pre-receive checks pointers against the pushing repository, not the pool. A pointer to an object that exists only in another repository would otherwise pass the push and then 404 on clone. The client re-uploads, the pool deduplicates and the link lands, which is the transfer cost isolation implies. - The sweep walks per repository, because reachability is per repository: an object reachable in one and not another keeps the first link and loses the second while the bytes stay. So `vole gc` is also the repair — it links what a repository reaches and unlinks what it no longer does. - An instance upgrading from the shared pool has no namespaces at all, so every fetch would 404 until somebody read an upgrade note. server.New notices a store with no namespace and runs the link pass in the background once, using gc.Link — the half of gc that creates links and deletes nothing, so an interrupted pass leaves the store more reachable than it found it. A repository rename moves its namespace with it. Reference counting stays rejected, and this makes the argument stronger: the thing that repairs the store is the same walk that cleans it, and it cannot invent a reference that does not exist. Measured: TestAnObjectIsInvisibleToARepositoryThatDoesNotHoldIt and the server level TestAnObjectIsNotFetchableThroughAnotherRepository (404 over the LFS endpoint for an object the shared store demonstrably has); TestTwoRepositoriesShareOneCopyOfTheBytes proves os.SameFile, so isolation costs no deduplication; TestOneRepositoryLosingAPointerKeepsTheOthersLink and TestLinkRepairsAMissingNamespace pin the per-repository sweep and the repair; TestAnUnscopedStoreIsLinkedOnStartup covers the upgrade path. Phase 5 is now complete: locking and object scoping both landed.
internal/lfs/transfer_test.go +3−3
| @@ -211,7 +211,7 @@ func TestTransferUploadThenDownload(t *testing.T) { | |||
| 211 | 211 | c.send("quit") | |
| 212 | 212 | done() | |
| 213 | 213 | ||
| 214 | if !store.Has(oid) { | ||
| 214 | if !store.Has("demo", oid) { | ||
| 215 | 215 | t.Fatal("the uploaded object is not in the store") | |
| 216 | 216 | } | |
| 217 | 217 | ||
| @@ -276,7 +276,7 @@ func TestTransferRejectsContentThatDoesNotMatchItsID(t *testing.T) { | |||
| 276 | 276 | if code != 422 { | |
| 277 | 277 | t.Fatalf("put-object answered %d (%v); want 422", code, lines) | |
| 278 | 278 | } | |
| 279 | if store.Has(claimed) { | ||
| 279 | if store.Has("demo", claimed) { | ||
| 280 | 280 | t.Fatal("mismatched content was stored") | |
| 281 | 281 | } | |
| 282 | 282 | ||
| @@ -305,7 +305,7 @@ func TestTransferBatchReportsNoopForObjectsItAlreadyHas(t *testing.T) { | |||
| 305 | 305 | store := New(t.TempDir(), 1<<20) | |
| 306 | 306 | data := []byte("already uploaded") | |
| 307 | 307 | oid := oidOf(data) | |
| 308 | if _, _, err := store.Put(oid, int64(len(data)), bytes.NewReader(data)); err != nil { | ||
| 308 | if _, _, err := store.Put("demo", oid, int64(len(data)), bytes.NewReader(data)); err != nil { | ||
| 309 | 309 | t.Fatal(err) | |
| 310 | 310 | } | |
| 311 | 311 | tr := &Transfer{Store: store, Repo: "demo", CanRead: true, CanWrite: true} | |