vole

Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Harden the web transport and bound the pages that run git

701232cf37157ff392e3b35a3279735d72e585d4 · Keenan Nemetz · 13d ago · parent 6bfc4294

Harden the web transport and bound the pages that run git

Generated clone and LFS download links were derived from the request's
Host header, with X-Forwarded-Proto believed from anyone. Those links are
copied out of a page and pasted into a terminal, and the LFS hrefs are
followed by a client, so a forged Host chose where somebody else's
download went.

Links now use public_url when it is configured, which is how a production
instance is meant to be set up; without it the request origin is all there
is, and forwarded headers are honoured only when git_http_client_ip_header
is set, because that is the instance's statement that a proxy it trusts
rewrites them. Site links follow the forge's scheme instead of always
saying http, so an HTTPS forge does not link to a mixed-content site.

The security headers now close the rest of the surface: object-src is
none, inline styles are no longer allowed (no template or generated
markup contains one), and Permissions-Policy, COOP and CORP are set. The
CSRF check gained a second lock: when the browser says where a request
came from, that origin must be this instance, on form posts and on the
JSON ceremony endpoints alike. A missing Origin and Referer is not
evidence, so only a request that names somewhere else is refused.

The pages that shell out to git are bounded. Search, compare, blame, file
history, commit history and both archive formats take a slot from a pool
of eight and run under a 30-second deadline, which is attached to the git
handle so the process is killed rather than left running after the reader
has gone. Past a five-second wait for a slot the page answers 503 with
Retry-After. Plain tar now takes the archive slot too: it is cheaper than
gzip, not free, and both stream for as long as the client reads.

Tests: clone URLs ignore a forged Host when public_url is set and honour
forwarded headers only behind a declared proxy; LFS hrefs likewise; site
links follow the scheme; the CSP has no unsafe-inline and names
object-src; a saturated git pool answers 503 with Retry-After; a
cross-origin post is refused with a valid CSRF token, end to end; the
JSON endpoints refuse a foreign origin.

Docs: public_url now explains that it decides generated links and that
forwarded headers are only trusted with the proxy header set; Sites gains
a same-site risk section recommending a separate registrable domain when
sites are not trusted.

server/web/overview.go +2−5

@@ -83,10 +83,7 @@ func (w Web) Overview(rw http.ResponseWriter, r http.Request) {
	83	83	}
	84	84
	85	85	readme, readmeName := w.readmeAt(m, ref, commit)
	86		site := ""
	87		if w.Cfg.PagesDomain != "" {
	88		site = "http://" + m.Name + "." + w.Cfg.PagesDomain
	89		}
		86	site := w.siteURL(r, m.Name)
	90	87
	91	88	w.render(rw, "overview", struct {
	92	89	Page
@@ -108,7 +105,7 @@ func (w Web) Overview(rw http.ResponseWriter, r http.Request) {
	108	105	Name: m.Name,
	109	106	Ref: ref,
	110	107	Commit: commit,
	111		CloneURL: cloneURL(r, m.Name),
		108	CloneURL: w.cloneURL(r, m.Name),
	112	109	SSHURL: sshURL(w.Cfg.SSHAddr, m.Name),
	113	110	Site: site,
	114	111	Readme: readme,