Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Say what each change is waiting for in the list

7cc36ba0f4ba96d3f4938b13758b2cc20c22375a · Keenan Nemetz · 5d ago · parent 946d2fd4

Say what each change is waiting for in the list

A change spends most of its life in states "open" cannot describe: held for a
maintainer to allow CI, running its checks, failed, waiting for a reviewer,
conflicting with its base. The list now says which of those it is, in one
column, with a tooltip that explains the label.

The answer comes from facts a list can afford: the approvals it already counts,
one batched run-queue query for every head on the page, the contributor
allowance (one ref listing, not one per row), and — only for a change that would
otherwise read as ready — whether it still merges into its base. The full
landing plan stays on the detail page.

The rest of the row follows the issue list: the author and opening moved under
the title, the comment count sits at the end of that line, and the last column
is "Updated", the newest commit over the request's directory. The list sorts by
it. The separate Author, Approvals and Age columns are gone.

Closes #194

docs/change-requests.md +19

@@ -257,6 +257,25 @@ A merged request keeps showing the change it landed. The mark records
257 257 head is in the base and a diff of the two is empty. That is what the Files tab
258 258 diffs when the request is already merged.
259 259
260 ## The change list
261
262 The change list shows one status per row, so the queue can be read without
263 opening every change:
264
265 - **Waiting on CI approval** — a contributor branch at this commit has not been
266 allowed by a maintainer yet.
267 - **Waiting on CI jobs** — checks for the commit are queued or running.
268 - **CI failed** — a check failed; pushing a fix starts a new review.
269 - **Waiting for review** — fewer current approvals than the base branch requires.
270 - **Merge conflict** — the branch no longer merges into its base cleanly.
271 - **Ready to merge** — the required approvals are in (or none are required) and
272 the commit's checks passed.
273 - **Merged**, **Closed** — the change landed, or was closed without landing.
274
275 The list also shows when each change was last updated: the newest commit that
276 touched its directory, which covers an edit, a comment, and an approval. It sorts
277 by that, so the change that moved most recently is first.
278
260 279 ## Review comments
261 280
262 281 ```sh