Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Fold admin work into repository settings and a Users page

9579c1f976254fdeb2ec73d4016db5b25c7921c1 · Keenan Nemetz · 14d ago · parent 381d6aac

Fold admin work into repository settings and a Users page

Remove the combined /admin tabs. Per-repository access rules now live on the repository's Settings page, visible to instance admins while repository details and the danger zone stay with repository admins. User management moves to /users, linked from the top navigation only for instance admins, and repository creation moves to /repos/new. Align the invite, danger-zone, and settings forms with the shared card-and-actions layout, and make settings section headings consistent.

server/admin_repos_test.go +7−7

@@ -18,7 +18,7 @@ func TestAdminCreatesRepository(t *testing.T) {
18 18 f.addWriter(t)
19 19 sess, cookie := f.browserSession(t, f.ownerID)
20 20
21 resp, body := f.browserGet(t, "/admin/repos/new", cookie)
21 resp, body := f.browserGet(t, "/repos/new", cookie)
22 22 if resp.StatusCode != 200 || !strings.Contains(body, "New repository") || !strings.Contains(body, "wilbur") {
23 23 t.Fatalf("new repository page = %d:\n%s", resp.StatusCode, body)
24 24 }
@@ -29,8 +29,8 @@ func TestAdminCreatesRepository(t *testing.T) {
29 29 "owner": {"wilbur"},
30 30 "description": {"second repository"},
31 31 }
32 resp, _ = f.browserPost(t, "/admin/repos", cookie, form)
33 if resp.StatusCode != 303 || resp.Header.Get("Location") != "/admin/repos/demo-two/access" {
32 resp, _ = f.browserPost(t, "/repos", cookie, form)
33 if resp.StatusCode != 303 || resp.Header.Get("Location") != "/r/demo-two/settings" {
34 34 t.Fatalf("create = %d %q", resp.StatusCode, resp.Header.Get("Location"))
35 35 }
36 36 m, err := f.srv.Repos.Open("demo-two")
@@ -66,20 +66,20 @@ func TestAdminCreatesRepository(t *testing.T) {
66 66 }
67 67
68 68 form.Set("csrf", sess.CSRF)
69 if resp, body := f.browserPost(t, "/admin/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "already exists") {
69 if resp, body := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "already exists") {
70 70 t.Fatalf("duplicate = %d:\n%s", resp.StatusCode, body)
71 71 }
72 72 form.Set("name", "Bad Name")
73 if resp, _ := f.browserPost(t, "/admin/repos", cookie, form); resp.StatusCode != 400 {
73 if resp, _ := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 400 {
74 74 t.Fatalf("invalid name = %d, want 400", resp.StatusCode)
75 75 }
76 76 form.Set("name", "third")
77 77 form.Set("owner", "nobody")
78 if resp, body := f.browserPost(t, "/admin/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "active account") {
78 if resp, body := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "active account") {
79 79 t.Fatalf("unknown owner = %d:\n%s", resp.StatusCode, body)
80 80 }
81 81 form.Del("csrf")
82 if resp, _ := f.browserPost(t, "/admin/repos", cookie, form); resp.StatusCode != 403 {
82 if resp, _ := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 403 {
83 83 t.Fatalf("missing CSRF = %d, want 403", resp.StatusCode)
84 84 }
85 85 }