Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Make the audit log one shape that a privileged change cannot skip

b1499c729a026cfda32d8a90374b3b8391ca0090 · Keenan Nemetz · 13d ago · parent d74d4de8

Make the audit log one shape that a privileged change cannot skip

Every writer used to format its own line and open its own file, so
data/audit.log held six different column layouts and a write that failed
changed nothing. A log that can be bypassed by a full disk, or by a key
comment containing a tab, is not the security promise the docs make.

internal/audit is now the only writer: one line per action, always
timestamp, action, actor, subject, detail. Every field is escaped and
capped at 4 KiB, so a key comment, an LFS lock path, a repository name or
an admin argument cannot add a column or a record. One write per line
under O_APPEND keeps the web, the SSH server and each hook process from
interleaving, and secure.OpenAppend keeps the file at 0600 including on an
upgrade from 0644.

Privileged changes now fail closed, and they are recorded before they
happen, so a failed write means the change did not occur:

  - roster, key and instance-role changes (inside the transaction)
  - access-rule changes, and a repository deletion, which records before
    removing content and forgets the rules only afterwards
  - session creation and revocation
  - a forced LFS unlock
  - an admin command over SSH, which reports audit_unavailable
  - a push that overrides a lock, an approval, a release or history

Ordinary pushes and web actions are reported instead: their changes are
already durable in git, so a write failure is logged at error level (or on
the pusher's terminal from post-receive) rather than making a working push
look rejected.

Opening an instance now checks the log is a regular file at 0600 owned by
the service account and appendable, and refuses to start otherwise. There
is no setting that disables the log or returns it to best effort.

Regression tests cover field injection through key comments, lock paths,
admin argv and repository names; 0600 on create and on upgrade; an
unwritable sink failing an ACL change, an account change, a session, a
forced unlock, an admin command and a push override while leaving the
underlying state unchanged; concurrent appends keeping whole lines; and
startup refusing a symlinked log.

forge/repo/repo.go +10−4

@@ -248,17 +248,23 @@ func (s *Store) Rename(oldName, newName string) error {
248 248 return s.InstallHooks(newDir)
249 249 }
250 250
251 func (s *Store) Delete(name string) error {
251 func (s *Store) Delete(name, actor string) error {
252 252 m, err := s.Open(name)
253 253 if err != nil {
254 254 return fmt.Errorf("repo %q not found", name)
255 255 }
256 // The deletion is recorded before anything is removed: a repository that
257 // vanishes without a line is exactly the event the audit log exists for. The
258 // rules themselves go only after the content is gone, so a removal that fails
259 // leaves a repository that can still be administered.
260 if s.ACLs != nil {
261 if err := s.ACLs.RecordDelete(m.ID, actor); err != nil {
262 return err
263 }
264 }
256 265 if err := os.RemoveAll(m.Dir); err != nil {
257 266 return err
258 267 }
259 // The rules go with the repository, and only after it is gone: a row without a
260 // repository is unreachable, while a repository without its row would deny
261 // everybody until somebody noticed.
262 268 if s.ACLs != nil {
263 269 return s.ACLs.Delete(m.ID)
264 270 }