Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Manage accounts from the users directory, not the Admin tab

ea21f923d1fabe3a633e3dc4713ca18d211dbfcb · Keenan Nemetz · 5d ago · parent f11854fe

Manage accounts from the users directory, not the Admin tab

The Accounts tab rendered every account in the roster, which costs more as
an instance grows and duplicates a directory that is already paginated,
searchable, filterable, and sortable. The tab now keeps the invite and bot
forms and points at /u, and an instance admin gets a Manage action on each
directory row that opens the account page.

The Manage column is presentation only: the account page still checks the
instance-admin role, so a non-admin who types its URL gets the usual 404.

Refs #198 (01M6MK0NNZ2XR1D5TQKNWYT4HN).

server/web/templates/people.html +2

@@ -33,6 +33,7 @@
33 33 <th{{if .Numeric}} class="count"{{end}}{{if .Active}} aria-sort="{{if .Desc}}descending{{else}}ascending{{end}}"{{end}}><a href="{{.Href}}">{{.Label}}{{if .Active}}<span class="sort-mark" aria-hidden="true">{{if .Desc}}↓{{else}}↑{{end}}</span>{{end}}</a></th>
34 34 {{end}}
35 35 {{if .ShowRole}}<th>Role</th>{{end}}
36 {{if .InstanceAdmin}}<th>Manage</th>{{end}}
36 37 </tr>
37 38 </thead>
38 39 <tbody>
@@ -45,6 +46,7 @@
45 46 <td class="count">{{.Summary.Reviews}}</td>
46 47 <td class="muted nowrap">{{.Joined.Format "Jan 2006"}}</td>
47 48 {{if $.ShowRole}}<td>{{if ne .Role "none"}}<span class="label">{{.Role}}</span>{{else}}<span class="muted">—</span>{{end}}</td>{{end}}
49 {{if $.InstanceAdmin}}<td><a href="/users/{{.Name}}">Manage</a></td>{{end}}
48 50 </tr>
49 51 {{end}}
50 52 </tbody>