Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Phase 4: access rules live in the instance database

ec5c519cb9fc4277baa8263cfd31891a95f1d7ac · Keenan Nemetz · 17d ago · parent 90fdaf39

Phase 4: access rules live in the instance database

The ACL was one acl.json on refs/vole/acl: a ref only the server writes, read on
every push and every request. It is configuration the instance owns, keyed by
account id, and keeping it in git cost a commit, a compare-and-swap retry and a
rev-parse per read to store a handful of rows — the argument that already moved
the roster out of data/system.git, applied to the rules that name its accounts.

It is now a row in data/users.db beside the roster, in the same file as the ids
it refers to:

- access.Store: repo_acl(repo_id, acl, updated, updated_by), one row per
  repository, keyed by the stable repository id so a rename moves nothing.
- Meta.ACL reads the row; a repository with no row is deny-everything, exactly
  what a missing ref meant.
- Meta.SetACL is one upsert, so SQLite orders concurrent edits and the CAS loop
  with its retries is gone. The author stays in the row and in data/audit.log,
  which is what the commit message used to say.
- Deleting a repository forgets its rules, after the directory is gone.
- repo.Store.ImportACLs reads refs/vole/acl once at startup for any repository
  without a row, so an existing instance keeps its rules. It never overwrites a
  row, and a second run imports nothing.
- The index's acl_sha is a digest of the rules rather than the ACL commit id.
- pre-receive reads the rules from VOLE_USERS_DB and makes GIT_DIR absolute
  before deriving the repository from it, since git hands a hook ".".

What the ref bought — rules that travel with a clone — is what this gives up,
deliberately: the rules are account ids, so a copy in a clone is unreadable
without this instance's roster, and the backup that holds the accounts now holds
them too.

Measured: internal/repo imports rules from a real refs/vole/acl commit and is
idempotent on a second run; internal/access covers round-trip, replacement,
deletion and the audit line; the full suite — auth, site visibility, transport
and pushes — runs against rules read from SQLite.

internal/pages/pages_test.go +9−1

@@ -3,11 +3,13 @@ package pages
3 3 import (
4 4 "net/http"
5 5 "net/http/httptest"
6 "path/filepath"
6 7 "strconv"
7 8 "strings"
8 9 "testing"
9 10 "time"
10 11
12 "github.com/rodent-software/vole/internal/access"
11 13 "github.com/rodent-software/vole/internal/acl"
12 14 "github.com/rodent-software/vole/internal/gitx"
13 15 "github.com/rodent-software/vole/internal/repo"
@@ -25,7 +27,13 @@ type fixture struct {
25 27 func newFixture(t testing.TB) *fixture {
26 28 t.Helper()
27 29 root := t.TempDir()
28 repos := repo.New(root, "/bin/true")
30 // Access rules live in the instance database; a site's visibility is one of them.
31 acls, err := access.Open(filepath.Join(root, "users.db"))
32 if err != nil {
33 t.Fatal(err)
34 }
35 t.Cleanup(func() { acls.Close() })
36 repos := repo.New(filepath.Join(root, "repos"), "/bin/true", acls)
29 37 m, err := repos.Create("site", "owner", "a site")
30 38 if err != nil {
31 39 t.Fatal(err)