Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Validate the configuration and harden what a deployment creates

ed1812123cd9e9df0f34fdaf0d2511a340c2aaa6 · Keenan Nemetz · 13d ago · parent 13cff33f

Validate the configuration and harden what a deployment creates

Two ways an instance used to run in a state it should have refused.

The configuration was never checked. `dev_login` was guarded only by a loopback
listener, so a proxy that rewrites Host to 127.0.0.1 inherited a credential-free
session; open registration could be enabled on a plain-HTTP origin WebAuthn would
never accept; a public_url could carry a path or credentials; a size could be
negative. Config.Validate now runs before anything is opened and reports every
problem at once, and dev_login requires an explicit dev_only opt-in next to a
loopback listener with no public address. The per-request check no longer trusts
Host at all: it must name the configured listener, and a request carrying a
forwarding header gets no session.

The files were never checked either. directories were created 0755 and the audit
log 0644, and a file keeps the mode it was created with, so an upgraded instance
stayed exposed. internal/secure creates secrets at 0600 in directories at 0700,
tightens what an existing install left, keeps group access for a shared backup
group, and refuses to start when a mode cannot be changed. Every audit writer and
the account backup go through it. The service unit drops all capabilities,
sets UMask=0027, disables core dumps, hides other processes and devices, and
restricts address families; docs/operations.md now states the production
baseline.

server/acme.go +2−2

@@ -5,10 +5,10 @@ import (
5 5 "crypto/tls"
6 6 "errors"
7 7 "fmt"
8 "github.com/rodent-software/vole/internal/secure"
8 9 "net"
9 10 "net/http"
10 11 "net/url"
11 "os"
12 12 "sort"
13 13 "strings"
14 14
@@ -84,7 +84,7 @@ func newACME(cfg *config.Config, sitePublic func(string) bool) (*acmeSetup, erro
84 84 // The cache holds the ACME account key. Create it up front so a permissions
85 85 // mistake is a startup error, not a failed handshake the first time somebody
86 86 // visits.
87 if err := os.MkdirAll(cachePath, 0o700); err != nil {
87 if err := secure.Mkdir(cachePath); err != nil {
88 88 return nil, fmt.Errorf("acme cache %s: %w", cachePath, err)
89 89 }
90 90 a.manager = &autocert.Manager{