Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Phase 4 slice 3: checks on the gate, and statuses on the page

35eaeccffdab9d07e13fb7b346060e535697fee7 · Keenan Nemetz · 17d ago · parent b44cbfaf

Phase 4 slice 3: checks on the gate, and statuses on the page

A protected branch now requires both an approved change request and passing checks
for the commit being landed. Approvals say a person read the change; checks say it
works. Neither substitutes for the other.

The gate asks about the *approved head*, not about the merge commit somebody may be
pushing: CI ran on the head, and a merge commit is a new object nobody built. That
also keeps the gate consistent with what approvals already name.

Details that decide whether this is usable:

- A repository with no workflows is unaffected — nothing to run means nothing to
  wait for — so existing repositories do not start failing pushes.
- A job with no run is refused with an explanation that names the branch filter,
  because `on: push: branches: [main]` never produces a result for a feature
  branch. That is the one configuration that can deadlock a merge, and the error
  says so instead of leaving somebody guessing.
- Failed, cancelled, still-running and missing are four different messages; a
  reviewer should be able to tell which.
- `vole acl checks <repo> on|off` turns it off, default on.

Statuses are readable: the repository page lists recent runs (job, commit, status,
attempts, age) and a change request shows its head's job statuses next to the
approvals, so the reviewer sees the same facts the gate uses.

Tests cover the three interesting shapes: approved + green lands; approved + red is
refused naming the failed job; approved + no run at all is refused with the
branch-filter hint.

Verified on a live instance: pushing a workflow queues and runs it, the repository
page shows `build · .vole/workflows/ci.yaml · success`, and the change request shows
`wilbur · current` alongside `build · success`.

Phase 4 is now complete except signed run records, which are Phase 7's.

docs/roadmap.md +6−1

@@ -253,9 +253,14 @@ token — long-polls for a lease, checks the commit out, runs the steps with per
253 253 timeouts, heartbeats while it works and reports the exit code and log. A lease that
254 254 expires returns the job to the queue; a job that kills five runners is failed.
255 255
256 ✅ **Slice 3 — checks on the gate.** A protected branch now needs green checks for the
257 approved head as well as approvals (`vole acl checks <repo> on|off`, default on; a
258 repository with no workflows is unaffected). The gate evaluates the approved head rather
259 than a merge commit, since CI runs on what was reviewed. Runs are shown on the repository
260 page and on each change request.
261
256 262 Remaining:
257 263
258 - Statuses on change requests and required-check gating (slice 3)
259 264 - Run records committed to a ref and signed by the instance key (Phase 7)
260 265 - Push-event queue persisted in SQLite, with at-least-once delivery
261 266 - Runner protocol: `vole runner` registers, long-polls for work, leases a job, heartbeats;