vole
Clone
Read only, no credentials:
https://rodent.software/git/vole.git
Write over SSH with a registered key:
git clone ssh://git@0.0.0.0:2222/vole.git
A free and open-source forge that lives in your Git repo.
Phase 4 slice 3: checks on the gate, and statuses on the page
35eaeccffdab9d07e13fb7b346060e535697fee7 · Keenan Nemetz · 17d ago · parent b44cbfaf
Phase 4 slice 3: checks on the gate, and statuses on the page A protected branch now requires both an approved change request and passing checks for the commit being landed. Approvals say a person read the change; checks say it works. Neither substitutes for the other. The gate asks about the *approved head*, not about the merge commit somebody may be pushing: CI ran on the head, and a merge commit is a new object nobody built. That also keeps the gate consistent with what approvals already name. Details that decide whether this is usable: - A repository with no workflows is unaffected — nothing to run means nothing to wait for — so existing repositories do not start failing pushes. - A job with no run is refused with an explanation that names the branch filter, because `on: push: branches: [main]` never produces a result for a feature branch. That is the one configuration that can deadlock a merge, and the error says so instead of leaving somebody guessing. - Failed, cancelled, still-running and missing are four different messages; a reviewer should be able to tell which. - `vole acl checks <repo> on|off` turns it off, default on. Statuses are readable: the repository page lists recent runs (job, commit, status, attempts, age) and a change request shows its head's job statuses next to the approvals, so the reviewer sees the same facts the gate uses. Tests cover the three interesting shapes: approved + green lands; approved + red is refused naming the failed job; approved + no run at all is refused with the branch-filter hint. Verified on a live instance: pushing a workflow queues and runs it, the repository page shows `build · .vole/workflows/ci.yaml · success`, and the change request shows `wilbur · current` alongside `build · success`. Phase 4 is now complete except signed run records, which are Phase 7's.
internal/acl/acl.go +13
| @@ -57,6 +57,19 @@ type ACL struct { | |||
| 57 | 57 | // may be pushed to a protected branch. Nil means the default of 1; an | |
| 58 | 58 | // explicit 0 means only admins may push, which is the pre-reviews behaviour. | |
| 59 | 59 | ApprovalsRequired *int `json:"approvals_required,omitempty"` | |
| 60 | // ChecksRequired gates a protected branch on CI having passed for the commit | ||
| 61 | // being landed. Nil means true: a repository with tests is expected to run | ||
| 62 | // them before merging. A repository with no workflows is unaffected, because | ||
| 63 | // there is nothing to run. | ||
| 64 | ChecksRequired *bool `json:"checks_required,omitempty"` | ||
| 65 | } | ||
| 66 | |||
| 67 | // RequiresChecks resolves the nil-means-true rule. | ||
| 68 | func (a *ACL) RequiresChecks() bool { | ||
| 69 | if a.ChecksRequired == nil { | ||
| 70 | return true | ||
| 71 | } | ||
| 72 | return *a.ChecksRequired | ||
| 60 | 73 | } | |
| 61 | 74 | ||
| 62 | 75 | // RequiredApprovals resolves the nil-means-default rule. | |