Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Tighten up the issue and change review pages

564acd4b6de233740f3c19e297c4655e8952d40c · Keenan Nemetz · 15d ago · parent a464f892

Tighten up the issue and change review pages

- Move contributor-branch CI approval from the Runs tab to the change
  request header, and return the allow form to that request.
- Put issue and change actions in the page header, right aligned with the
  title, instead of duplicating them in the sidebar.
- Drop sidebar details that repeated the header: state, author, age and
  reference. Keep labels, assignees, review base/head, approvals and checks.
- Consolidate approval status into one section and remove the empty-state
  line now covered by the count.
- Fix diff row spacing: keep pre-wrap on the code column only, so template
  whitespace in the gutter cells no longer creates blank lines.

Update the contributor CI test, the HTMX fragment expectations and the
documentation that named the Runs tab as the approval location.

server/web/templates/issues.html +9−25

@@ -92,21 +92,6 @@
92 92 </div>
93 93 {{end}}
94 94
95 {{define "issue_state"}}
96 <section id="issue-state">
97 <h2>{{icon "circle-dot"}}State</h2>
98 {{if .Error}}<p class="error">{{.Error}}</p>{{end}}
99 <p><span class="state {{.Issue.State}}">{{.Issue.State}}</span></p>
100 {{if .CanClose}}
101 <form method="post" action="/r/{{.Name}}/issues/{{.Issue.ID}}/state" hx-post="/r/{{.Name}}/issues/{{.Issue.ID}}/state" hx-target="#issue-state" hx-swap="outerHTML" hx-disabled-elt="find button[type='submit']">
102 <input type="hidden" name="csrf" value="{{.CSRF}}">
103 <input type="hidden" name="state" value="{{if eq .Issue.State "open"}}closed{{else}}open{{end}}">
104 <button class="secondary" type="submit">{{if eq .Issue.State "open"}}{{icon "circle-x"}}Close issue{{else}}{{icon "rotate-ccw"}}Reopen issue{{end}}</button>
105 </form>
106 {{end}}
107 </section>
108 {{end}}
109
110 95 {{define "issue_labels"}}
111 96 <section id="issue-labels">
112 97 <h2>{{icon "tag"}}Labels</h2>
@@ -192,6 +177,15 @@
192 177 · opened by {{who .Issue.Author}} {{since .Issue.Created.Unix}}
193 178 </p>
194 179 </div>
180 {{if .CanClose}}
181 <div class="page-head-actions">
182 <form method="post" action="/r/{{.Name}}/issues/{{.Issue.ID}}/state">
183 <input type="hidden" name="csrf" value="{{.CSRF}}">
184 <input type="hidden" name="state" value="{{if eq .Issue.State "open"}}closed{{else}}open{{end}}">
185 <button class="secondary" type="submit">{{if eq .Issue.State "open"}}{{icon "circle-x"}}Close issue{{else}}{{icon "rotate-ccw"}}Reopen issue{{end}}</button>
186 </form>
187 </div>
188 {{end}}
195 189 </div>
196 190
197 191 <div class="thread">
@@ -229,18 +223,8 @@
229 223 </div>
230 224
231 225 <aside class="thread-side">
232 {{template "issue_state" .}}
233 226 {{template "issue_labels" .}}
234 227 {{template "issue_assignees" .}}
235
236 <section>
237 <h2>{{icon "info"}}Details</h2>
238 <dl class="meta-list">
239 <dt>Author</dt><dd>{{who .Issue.Author}}</dd>
240 <dt>Opened</dt><dd>{{since .Issue.Created.Unix}}</dd>
241 <dt>Reference</dt><dd class="sha">#{{short .Issue.ID}}</dd>
242 </dl>
243 </section>
244 228 </aside>
245 229 </div>
246 230 {{template "footer" .}}