Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Tighten up the issue and change review pages

564acd4b6de233740f3c19e297c4655e8952d40c · Keenan Nemetz · 15d ago · parent a464f892

Tighten up the issue and change review pages

- Move contributor-branch CI approval from the Runs tab to the change
  request header, and return the allow form to that request.
- Put issue and change actions in the page header, right aligned with the
  title, instead of duplicating them in the sidebar.
- Drop sidebar details that repeated the header: state, author, age and
  reference. Keep labels, assignees, review base/head, approvals and checks.
- Consolidate approval status into one section and remove the empty-state
  line now covered by the count.
- Fix diff row spacing: keep pre-wrap on the code column only, so template
  whitespace in the gutter cells no longer creates blank lines.

Update the contributor CI test, the HTMX fragment expectations and the
documentation that named the Runs tab as the approval location.

server/web/web.go −21

@@ -298,27 +298,6 @@ func (w *Web) codeShell(r *http.Request, m *repo.Meta, ref, commit, active strin
298 298 return v
299 299 }
300 300
301 // contributorBranchState lists the branches whose CI is waiting for a maintainer
302 // and reports whether this viewer may approve them. The Runs page owns the
303 // control; the code browser is only for reading files.
304 func (w *Web) contributorBranchState(r *http.Request, m *repo.Meta) ([]string, bool) {
305 refs, _ := m.Git().ListRefs("refs/heads/")
306 var names []string
307 for ref := range refs {
308 if _, ok := access.ContributorRefName(ref); ok {
309 names = append(names, strings.TrimPrefix(ref, "refs/heads/"))
310 }
311 }
312 sort.Strings(names)
313 canAllow := false
314 if acl, err := m.ACL(); err == nil {
315 if id := w.accountID(r); id != "" && acl.CanApprove(id) {
316 canAllow = true
317 }
318 }
319 return names, canAllow
320 }
321
322 301 func (w *Web) Tree(rw http.ResponseWriter, r *http.Request) {
323 302 m, ok := w.open(rw, r)
324 303 if !ok {