Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Apply a push's index delta as the push lands, and check the ref by reading it

dced06da1bfc4a8e542e5d86d67888362077ed39 · Keenan Nemetz · 9d ago · parent 26c9be33

Apply a push's index delta as the push lands, and check the ref by reading it

A push's metadata delta used to be applied by the next reader, so the
first page after a big push paid for the whole push. And search checked
every visible repository before querying: a `symbolic-ref` to open it and
a `rev-parse` to see whether the metadata branch moved, so N repositories
cost 2N git processes per search.

- Post-receive now opens the index (the SSH server hands it `VOLE_INDEX_DB`
  and the repository id) and runs Ensure after the refs have moved, which
  is also after a followed request's head has moved. A failure is reported
  and ignored: the refs have landed, and the next read still repairs it.
- `git.Repo.RefCommit` resolves a branch ref by reading the loose ref file
  git writes for every branch update, and falls back to `rev-parse` for a
  packed ref, a symbolic ref, or a missing one. The index's Ensure and the
  web's metadata-head read use it.
- `repo.Store.Meta` builds a repository handle without a HEAD lookup, and
  search uses it: the refresh needs the directory and the ACL, not the
  default branch. The per-repository check is now two file reads instead
  of two processes.

Load harness, `search-find` at concurrency 4 over three repositories:
510.2 req/s and p50 7 ms before, 814.8 req/s and p50 4 ms after. A push
that changes the `vole` branch leaves the rows current before the push
returns; a test queries them with no Ensure in between.

forge/index/refresh.go +2−2

@@ -23,7 +23,7 @@ import (
23 23 // read is reserved for the cases that need it: the first read, a rewritten
24 24 // branch, or an incremental refresh that cannot be trusted.
25 25 func (s *Store) Ensure(m *repo.Meta) error {
26 current, err := m.Git().RevParse(metadata.Ref)
26 current, err := m.Git().RefCommit(metadata.Ref)
27 27 if err != nil {
28 28 return err
29 29 }
@@ -64,7 +64,7 @@ func (s *Store) EnsureIssues(m *repo.Meta) error { return s.Ensure(m) }
64 64 // the same rows, and `vole admin index rebuild` is this function for every repo.
65 65 func (s *Store) IndexRepo(m *repo.Meta) error {
66 66 g := m.Git()
67 commit, err := g.RevParse(metadata.Ref)
67 commit, err := g.RefCommit(metadata.Ref)
68 68 if err != nil {
69 69 return err
70 70 }