Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Apply a push's index delta as the push lands, and check the ref by reading it

dced06da1bfc4a8e542e5d86d67888362077ed39 · Keenan Nemetz · 9d ago · parent 26c9be33

Apply a push's index delta as the push lands, and check the ref by reading it

A push's metadata delta used to be applied by the next reader, so the
first page after a big push paid for the whole push. And search checked
every visible repository before querying: a `symbolic-ref` to open it and
a `rev-parse` to see whether the metadata branch moved, so N repositories
cost 2N git processes per search.

- Post-receive now opens the index (the SSH server hands it `VOLE_INDEX_DB`
  and the repository id) and runs Ensure after the refs have moved, which
  is also after a followed request's head has moved. A failure is reported
  and ignored: the refs have landed, and the next read still repairs it.
- `git.Repo.RefCommit` resolves a branch ref by reading the loose ref file
  git writes for every branch update, and falls back to `rev-parse` for a
  packed ref, a symbolic ref, or a missing one. The index's Ensure and the
  web's metadata-head read use it.
- `repo.Store.Meta` builds a repository handle without a HEAD lookup, and
  search uses it: the refresh needs the directory and the ACL, not the
  default branch. The per-repository check is now two file reads instead
  of two processes.

Load harness, `search-find` at concurrency 4 over three repositories:
510.2 req/s and p50 7 ms before, 814.8 req/s and p50 4 ms after. A push
that changes the `vole` branch leaves the rows current before the push
returns; a test queries them with no Ensure in between.

server/index_hook_test.go +35

@@ -0,0 +1,35 @@
1 package server_test
2
3 // The index used to become current on the next read, which put the delta of a
4 // push inside a page render. Post-receive applies it as the push lands; this is
5 // the wiring test: a push, then a query with no Ensure in between.
6
7 import (
8 "testing"
9
10 "github.com/rodent-software/vole/forge/index"
11 )
12
13 func TestPushRefreshesTheIndexBeforeTheNextRead(t *testing.T) {
14 t.Parallel()
15 f := newFixture(t)
16 f.publish(f.repo)
17 m := mustRepo(t, f)
18
19 work := f.issuesRepo(t, issueFiles(testIssueID, "Indexed by the push", "body\n"))
20 if _, errs, err := f.git(work, "push", f.sshURL(f.repo), "HEAD:refs/heads/vole"); err != nil {
21 t.Fatalf("push issues: %v\n%s", err, errs)
22 }
23
24 // No Ensure: post-receive ran in the push, so the rows are already there.
25 rows, err := f.srv.Index.Issues(m.ID, index.Filter{})
26 if err != nil {
27 t.Fatal(err)
28 }
29 if len(rows) != 1 || rows[0].ID != testIssueID {
30 t.Fatalf("the push did not refresh the index: %+v", rows)
31 }
32 if rows[0].Title != "Indexed by the push" {
33 t.Fatalf("row title = %q", rows[0].Title)
34 }
35 }