vole
Clone
Read only, no credentials:
https://rodent.software/vole.git
Write over SSH with a registered key:
git clone ssh://git@rodent.software:2222/vole.git
A free and open-source forge that lives in your Git repo.
Remove the merge confetti and canvas-confetti
8032d15aa32facad8f21fad931187520ee81c02b · Keenan Nemetz · 6d ago · parent ac541b26
Remove the merge confetti and canvas-confetti A landing no longer celebrates: the request page is the result, and the vendored library, its loader, and the ?merged=1 flag existed only for the burst. Dropping the flag means a landing redirects to the plain request page. Remove the asset, its license, the NOTICE entry, the loader and its test, and the comments that described them.
server/issues_changes_test.go +5−7
| @@ -1101,11 +1101,9 @@ func TestCommentEditAndDeleteFromTheWeb(t *testing.T) { | |||
| 1101 | 1101 | } | |
| 1102 | 1102 | } | |
| 1103 | 1103 | ||
| 1104 | // Landing is the one write that comes back with a flag on it, because the page it | ||
| 1105 | // lands on has to know the difference between "you just merged this" and "you are | ||
| 1106 | // reading this". The flag belongs to the redirect only: the request page renders | ||
| 1107 | // exactly the same with it present. | ||
| 1108 | func TestMergingRedirectsWithTheCelebrationFlag(t *testing.T) { | ||
| 1104 | // Landing redirects to the request page, which now reads as merged. The redirect | ||
| 1105 | // carries no flag: the page shows the merged state from the request itself. | ||
| 1106 | func TestLandingRedirectsToTheRequestPage(t *testing.T) { | ||
| 1109 | 1107 | t.Parallel() | |
| 1110 | 1108 | f := newFixture(t) | |
| 1111 | 1109 | f.publish(f.repo) | |
| @@ -1131,12 +1129,12 @@ func TestMergingRedirectsWithTheCelebrationFlag(t *testing.T) { | |||
| 1131 | 1129 | if resp.StatusCode != http.StatusSeeOther { | |
| 1132 | 1130 | t.Fatalf("merge = %d, want 303:\n%s", resp.StatusCode, body) | |
| 1133 | 1131 | } | |
| 1134 | want := "/r/" + f.repo + "/requests/" + reqID + "?merged=1" | ||
| 1132 | want := "/r/" + f.repo + "/requests/" + reqID | ||
| 1135 | 1133 | if got := resp.Header.Get("Location"); got != want { | |
| 1136 | 1134 | t.Fatalf("merge redirect = %q, want %q", got, want) | |
| 1137 | 1135 | } | |
| 1138 | 1136 | ||
| 1139 | // The page the flag points at is the ordinary merged view, not a special case. | ||
| 1137 | // The page it points at is the ordinary merged view, not a special case. | ||
| 1140 | 1138 | resp, page := f.browserGet(t, want, cookie) | |
| 1141 | 1139 | if resp.StatusCode != http.StatusOK { | |
| 1142 | 1140 | t.Fatalf("landing page = %d", resp.StatusCode) | |