Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Remove the merge confetti and canvas-confetti

8032d15aa32facad8f21fad931187520ee81c02b · Keenan Nemetz · 6d ago · parent ac541b26

Remove the merge confetti and canvas-confetti

A landing no longer celebrates: the request page is the result, and the vendored library, its loader, and the ?merged=1 flag existed only for the burst. Dropping the flag means a landing redirects to the plain request page.

Remove the asset, its license, the NOTICE entry, the loader and its test, and the comments that described them.

server/web/writes.go +2−4

@@ -635,10 +635,8 @@ func (w *Web) MergeRequest(rw http.ResponseWriter, r *http.Request) {
635 635 if problems := metadata.ValidateRequests(m.Git(), metadata.Ref); len(problems) > 0 {
636 636 w.Logger("web: merge left the request tree invalid: %v", problems)
637 637 }
638 // The parameter is how the page knows a landing just happened rather than a
639 // reader arriving: it is what makes a one-off celebration possible without
640 // replaying it on every visit, reload or shared link.
641 http.Redirect(rw, r, "/r/"+m.Name+"/requests/"+id+"?merged=1", http.StatusSeeOther)
638 // The redirect shows the request page, which now reads as merged.
639 http.Redirect(rw, r, "/r/"+m.Name+"/requests/"+id, http.StatusSeeOther)
642 640 }
643 641
644 642 // armMerge records "merge when ready" and answers the click. The intent is a wait,