Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 4h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/activity_test.go +5−5

@@ -30,7 +30,7 @@ func TestActivityShowsStateChangesAndFilters(t *testing.T) {
30 30
31 31 sess, cookie := f.browserSession(t, f.ownerID)
32 32 for _, state := range []string{"closed", "open"} {
33 resp, _ := f.browserPost(t, "/r/"+f.repo+"/issues/"+closedID+"/state", cookie, url.Values{
33 resp, _ := f.browserPost(t, "/"+f.repo+"/issues/"+closedID+"/state", cookie, url.Values{
34 34 "csrf": {sess.CSRF}, "state": {state},
35 35 })
36 36 if resp.StatusCode != 303 {
@@ -38,22 +38,22 @@ func TestActivityShowsStateChangesAndFilters(t *testing.T) {
38 38 }
39 39 }
40 40
41 _, body := f.get("/r/" + f.repo + "/activity?kind=issues")
41 _, body := f.get("/" + f.repo + "/activity?kind=issues")
42 42 for _, want := range []string{"closed issue", "reopened issue", "Closed then reopened", "Assigned issue"} {
43 43 if !strings.Contains(body, want) {
44 44 t.Fatalf("activity does not show %q:\n%s", want, body)
45 45 }
46 46 }
47 47
48 _, body = f.get("/r/" + f.repo + "/activity?kind=issues&actor=keenan")
48 _, body = f.get("/" + f.repo + "/activity?kind=issues&actor=keenan")
49 49 if !strings.Contains(body, "closed issue") || !strings.Contains(body, "Assigned issue") {
50 50 t.Fatalf("actor filter dropped keenan's events:\n%s", body)
51 51 }
52 if _, body := f.get("/r/" + f.repo + "/activity?kind=issues&actor=wilbur"); strings.Contains(body, "Closed then reopened") {
52 if _, body := f.get("/" + f.repo + "/activity?kind=issues&actor=wilbur"); strings.Contains(body, "Closed then reopened") {
53 53 t.Fatalf("actor filter kept another account's events:\n%s", body)
54 54 }
55 55
56 _, body = f.get("/r/" + f.repo + "/activity?kind=issues&assignee=wilbur")
56 _, body = f.get("/" + f.repo + "/activity?kind=issues&assignee=wilbur")
57 57 if !strings.Contains(body, "Assigned issue") {
58 58 t.Fatalf("assignee filter dropped the assigned issue:\n%s", body)
59 59 }