Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 5h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/compress_test.go +6−6

@@ -51,7 +51,7 @@ func TestPagesAreCompressedWhenTheClientAsks(t *testing.T) {
51 51 f := newFixture(t)
52 52 f.publish(f.repo)
53 53
54 resp := f.gzipGet(t, "/r/"+f.repo+"/code", nil)
54 resp := f.gzipGet(t, "/"+f.repo+"/code", nil)
55 55 if resp.StatusCode != http.StatusOK {
56 56 t.Fatalf("code page = %d", resp.StatusCode)
57 57 }
@@ -82,7 +82,7 @@ func TestCompressionIsOptional(t *testing.T) {
82 82 f := newFixture(t)
83 83 f.publish(f.repo)
84 84
85 resp := f.gzipGet(t, "/r/"+f.repo+"/code", map[string]string{"Accept-Encoding": "identity"})
85 resp := f.gzipGet(t, "/"+f.repo+"/code", map[string]string{"Accept-Encoding": "identity"})
86 86 if resp.StatusCode != http.StatusOK {
87 87 t.Fatalf("code page = %d", resp.StatusCode)
88 88 }
@@ -105,7 +105,7 @@ func TestStaticAssetsRevalidate(t *testing.T) {
105 105 t.Parallel()
106 106 f := newFixture(t)
107 107
108 resp := f.gzipGet(t, "/static/vole.css", map[string]string{"Accept-Encoding": "identity"})
108 resp := f.gzipGet(t, "/-/static/vole.css", map[string]string{"Accept-Encoding": "identity"})
109 109 if resp.StatusCode != http.StatusOK {
110 110 t.Fatalf("stylesheet = %d", resp.StatusCode)
111 111 }
@@ -124,7 +124,7 @@ func TestStaticAssetsRevalidate(t *testing.T) {
124 124 t.Fatal("stylesheet is empty")
125 125 }
126 126
127 notModified := f.gzipGet(t, "/static/vole.css", map[string]string{
127 notModified := f.gzipGet(t, "/-/static/vole.css", map[string]string{
128 128 "Accept-Encoding": "identity",
129 129 "If-None-Match": etag,
130 130 })
@@ -137,7 +137,7 @@ func TestStaticAssetsRevalidate(t *testing.T) {
137 137
138 138 // The compressed representation keeps the same validator, so a cache keys the
139 139 // two variants by Vary rather than by ETag.
140 compressed := f.gzipGet(t, "/static/vole.css", nil)
140 compressed := f.gzipGet(t, "/-/static/vole.css", nil)
141 141 if compressed.Header.Get("ETag") != etag {
142 142 t.Fatalf("compressed ETag = %q, want %q", compressed.Header.Get("ETag"), etag)
143 143 }
@@ -154,7 +154,7 @@ func TestStaticAssetsRevalidate(t *testing.T) {
154 154 func TestStaticServesOnlyTheEmbeddedSet(t *testing.T) {
155 155 t.Parallel()
156 156 f := newFixture(t)
157 for _, path := range []string{"/static/", "/static/nope.js", "/static/../go.mod"} {
157 for _, path := range []string{"/-/static/", "/-/static/nope.js", "/-/static/../go.mod"} {
158 158 resp := f.gzipGet(t, path, map[string]string{"Accept-Encoding": "identity"})
159 159 if resp.StatusCode != http.StatusNotFound {
160 160 t.Fatalf("%s = %d, want 404", path, resp.StatusCode)