Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/git/vole.git

Write over SSH with a registered key:

git clone ssh://git@0.0.0.0:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 5h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/lfs_test.go +4−4

@@ -215,7 +215,7 @@ func TestLFSBatchProtocol(t *testing.T) {
215 215 }
216 216
217 217 // The object endpoint refuses unknown ids rather than looking them up.
218 if code, _ := f.get("/git/" + f.repo + ".git/info/lfs/objects/" + strings.Repeat("b", 64)); code != 404 {
218 if code, _ := f.get("/" + f.repo + ".git/info/lfs/objects/" + strings.Repeat("b", 64)); code != 404 {
219 219 t.Fatalf("GET of an absent object = %d, want 404", code)
220 220 }
221 221 }
@@ -229,7 +229,7 @@ func TestLFSIsHiddenInPrivateRepos(t *testing.T) {
229 229 if err != nil {
230 230 t.Fatal(err)
231 231 }
232 if code, body := f.get("/git/" + f.repo + ".git/info/lfs/objects/" + oid); code != 404 {
232 if code, body := f.get("/" + f.repo + ".git/info/lfs/objects/" + oid); code != 404 {
233 233 t.Fatalf("object GET in a private repo = %d: %s", code, body)
234 234 }
235 235 raw, _ := json.Marshal(lfs.BatchRequest{Operation: "download", Objects: []lfs.Object{{OID: oid}}})
@@ -264,7 +264,7 @@ func TestAnObjectIsNotFetchableThroughAnotherRepository(t *testing.T) {
264 264 t.Fatalf("the fixture did not store the object: %v", err)
265 265 }
266 266 // But not through this repository.
267 code, _ := f.get("/git/" + f.repo + ".git/info/lfs/objects/" + oid)
267 code, _ := f.get("/" + f.repo + ".git/info/lfs/objects/" + oid)
268 268 if code != 404 {
269 269 t.Fatalf("another repository's object answered %d, want 404", code)
270 270 }
@@ -273,7 +273,7 @@ func TestAnObjectIsNotFetchableThroughAnotherRepository(t *testing.T) {
273 273 if _, _, err := f.srv.LFS.Put(f.repo, oid, int64(len(secret)), bytes.NewReader(secret)); err != nil {
274 274 t.Fatal(err)
275 275 }
276 code, body := f.get("/git/" + f.repo + ".git/info/lfs/objects/" + oid)
276 code, body := f.get("/" + f.repo + ".git/info/lfs/objects/" + oid)
277 277 if code != 200 || body != string(secret) {
278 278 t.Fatalf("own object = %d %q", code, body)
279 279 }