Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 9h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/acme_test.go +2−2

@@ -87,13 +87,13 @@ func TestACMEHTTPRedirectsOnlyKnownHosts(t *testing.T) {
87 87 }
88 88 h := a.httpHandler()
89 89
90 req := httptest.NewRequest(http.MethodGet, "http://forge.example.com/r/demo?tab=code", nil)
90 req := httptest.NewRequest(http.MethodGet, "http://forge.example.com/demo?tab=code", nil)
91 91 rec := httptest.NewRecorder()
92 92 h.ServeHTTP(rec, req)
93 93 if rec.Code != http.StatusMovedPermanently {
94 94 t.Fatalf("status = %d, want 301", rec.Code)
95 95 }
96 if got, want := rec.Header().Get("Location"), "https://forge.example.com:8443/r/demo?tab=code"; got != want {
96 if got, want := rec.Header().Get("Location"), "https://forge.example.com:8443/demo?tab=code"; got != want {
97 97 t.Fatalf("Location = %q, want %q", got, want)
98 98 }
99 99