Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 8h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/tag_release_test.go +5−5

@@ -76,14 +76,14 @@ func TestTagPushBuildsARelease(t *testing.T) {
76 76
77 77 // The release page is the proof: the runner committed the pointers, and the web
78 78 // reads them exactly as it reads a person's `vole release attach`.
79 code, page := f.get("/r/" + f.repo + "/releases/v1.0.0")
79 code, page := f.get("/" + f.repo + "/releases/v1.0.0")
80 80 if code != 200 {
81 81 t.Fatalf("release page = %d", code)
82 82 }
83 83 if !strings.Contains(page, "tool-linux") {
84 84 t.Fatalf("release page does not show the built artifact:\n%s", page)
85 85 }
86 code, body := f.get("/r/" + f.repo + "/releases/v1.0.0/artifacts/tool-linux")
86 code, body := f.get("/" + f.repo + "/releases/v1.0.0/artifacts/tool-linux")
87 87 if code != 200 || body != "release binary\n" {
88 88 t.Fatalf("artifact download = %d %q", code, body)
89 89 }
@@ -103,7 +103,7 @@ func TestTagPushBuildsARelease(t *testing.T) {
103 103 t.Fatalf("the release commit still carries a run record; it has:\n%s", tip)
104 104 }
105 105 // And the run page shows the tag it built for.
106 if _, runPage := f.get("/r/" + f.repo + "/runs/" + done.ID); !strings.Contains(runPage, "tag v1.0.0") {
106 if _, runPage := f.get("/" + f.repo + "/runs/" + done.ID); !strings.Contains(runPage, "tag v1.0.0") {
107 107 t.Fatalf("run page does not show the tag:\n%s", runPage)
108 108 }
109 109 }
@@ -130,12 +130,12 @@ func TestTagPushRefusesALightweightTag(t *testing.T) {
130 130 }
131 131 f.runOnce(t)
132 132 failed := f.waitForRun(t, 10*time.Second, func(r *runs.Run) bool { return r.Status == runs.StatusFailed })
133 _, log := f.get("/r/" + f.repo + "/runs/" + failed.ID + "/log")
133 _, log := f.get("/" + f.repo + "/runs/" + failed.ID + "/log")
134 134 if !strings.Contains(log, "lightweight tag") {
135 135 t.Fatalf("the failure does not explain itself:\n%s", log)
136 136 }
137 137 // Nothing was published, so the release page has no artifacts.
138 if _, page := f.get("/r/" + f.repo + "/releases/v2.0.0"); strings.Contains(page, "tool-linux") {
138 if _, page := f.get("/" + f.repo + "/releases/v2.0.0"); strings.Contains(page, "tool-linux") {
139 139 t.Fatalf("a lightweight tag got release artifacts:\n%s", page)
140 140 }
141 141 }