Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 8h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/goimport_test.go +7−5

@@ -19,7 +19,7 @@ func TestPublicRepositoryServesGoImportMetadata(t *testing.T) {
19 19 f := newFixtureWith(t, func(c *config.Config) { c.PublicURL = site })
20 20 f.publish(f.repo)
21 21
22 tag := fmt.Sprintf(`<meta name="go-import" content="forge.example.com/%s git %s/git/%s.git">`, f.repo, site, f.repo)
22 tag := fmt.Sprintf(`<meta name="go-import" content="forge.example.com/%s git %s/%s.git">`, f.repo, site, f.repo)
23 23 for _, path := range []string{
24 24 "/" + f.repo + "?go-get=1",
25 25 // A package inside the module asks at its own path first; the same tag
@@ -46,9 +46,12 @@ func TestPublicRepositoryServesGoImportMetadata(t *testing.T) {
46 46 t.Fatalf("content type = %q, want HTML", ct)
47 47 }
48 48
49 // Without the probe, the path is not a page: the styled 404 is unchanged.
50 if code, body := f.get("/" + f.repo); code != http.StatusNotFound || !strings.Contains(body, "Not found") {
51 t.Fatalf("/%s = %d, want the styled 404", f.repo, code)
49 // Without the probe the path is the repository page: the module path and the
50 // page a person opens are the same URL.
51 for _, path := range []string{"/" + f.repo, "/" + f.repo + "?go-get=0"} {
52 if code, _ := f.get(path); code != http.StatusOK {
53 t.Fatalf("%s = %d, want the repository page", path, code)
54 }
52 55 }
53 56 }
54 57
@@ -71,7 +74,6 @@ func TestGoImportIgnoresPathsThatNameNoRepository(t *testing.T) {
71 74 for _, path := range []string{
72 75 "/no-such-repository?go-get=1",
73 76 "/no-such-repository/pkg?go-get=1",
74 "/" + f.repo + "?go-get=0",
75 77 } {
76 78 if code, _ := f.get(path); code != http.StatusNotFound {
77 79 t.Fatalf("%s = %d, want 404", path, code)