Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 9h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/runners_page_test.go +9−9

@@ -47,15 +47,15 @@ func TestAdminRunnersTabShowsAHeldJobAndTheQueueDepth(t *testing.T) {
47 47 t.Fatal(err)
48 48 }
49 49
50 code, body := f.adminGet(t, "/admin?tab=runners")
50 code, body := f.adminGet(t, "/-/admin?tab=runners")
51 51 if code != 200 {
52 52 t.Fatalf("GET /admin?tab=runners = %d\n%s", code, body)
53 53 }
54 54 for _, want := range []string{
55 "keenan", // the account the key resolved to
56 "/r/demo/runs/" + building.ID, // the job it is building, linked
57 "building", // its job name
58 "Waiting", "Running", "demo", // the queue, per repository
55 "keenan", // the account the key resolved to
56 "/demo/runs/" + building.ID, // the job it is building, linked
57 "building", // its job name
58 "Waiting", "Running", "demo", // the queue, per repository
59 59 } {
60 60 if !strings.Contains(body, want) {
61 61 t.Errorf("the runners page does not mention %q:\n%s", want, body)
@@ -93,7 +93,7 @@ func TestAdminRunnersTabSaysWhenARepositoryIsAtItsCap(t *testing.T) {
93 93 t.Fatal(err)
94 94 }
95 95
96 code, body := f.adminGet(t, "/admin?tab=runners")
96 code, body := f.adminGet(t, "/-/admin?tab=runners")
97 97 if code != 200 {
98 98 t.Fatalf("GET /admin?tab=runners = %d\n%s", code, body)
99 99 }
@@ -105,11 +105,11 @@ func TestAdminRunnersTabSaysWhenARepositoryIsAtItsCap(t *testing.T) {
105 105 func TestRunnersRedirectsToAdmin(t *testing.T) {
106 106 t.Parallel()
107 107 f := newFixture(t)
108 resp, _ := f.browserGet(t, "/runners", "")
108 resp, _ := f.browserGet(t, "/-/runners", "")
109 109 if resp.StatusCode != http.StatusMovedPermanently {
110 110 t.Fatalf("GET /runners = %d, want a redirect", resp.StatusCode)
111 111 }
112 if got := resp.Header.Get("Location"); got != "/admin?tab=runners" {
112 if got := resp.Header.Get("Location"); got != "/-/admin?tab=runners" {
113 113 t.Fatalf("GET /runners redirected to %q", got)
114 114 }
115 115 }
@@ -130,7 +130,7 @@ func TestAdminRunnersTabShowsWhatEachRunnerTakes(t *testing.T) {
130 130 t.Fatal(err)
131 131 }
132 132
133 code, body := f.adminGet(t, "/admin?tab=runners")
133 code, body := f.adminGet(t, "/-/admin?tab=runners")
134 134 if code != 200 {
135 135 t.Fatalf("GET /admin?tab=runners = %d\n%s", code, body)
136 136 }