Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 9h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/web/home_test.go +17−17

@@ -9,15 +9,15 @@ func TestPaginateClampsToTheFeed(t *testing.T) {
9 9 if len(page) != 50 || p.Page != 1 || p.Pages != 3 || p.From != 1 || p.To != 50 {
10 10 t.Fatalf("page 1 = len %d, %+v", len(page), p)
11 11 }
12 if p.PrevURL != "" || p.NextURL != "/activity?page=2" {
12 if p.PrevURL != "" || p.NextURL != "/-/activity?page=2" {
13 13 t.Fatalf("page 1 links = %q, %q", p.PrevURL, p.NextURL)
14 14 }
15 15 page, p = paginate(events, 2, 50, instanceActivityURL(""), "Activity pages")
16 if len(page) != 50 || p.PrevURL != "/activity" || p.NextURL != "/activity?page=3" {
16 if len(page) != 50 || p.PrevURL != "/-/activity" || p.NextURL != "/-/activity?page=3" {
17 17 t.Fatalf("page 2 = len %d, %+v", len(page), p)
18 18 }
19 19 page, p = paginate(events, 3, 50, instanceActivityURL(""), "Activity pages")
20 if len(page) != 20 || p.PrevURL != "/activity?page=2" || p.NextURL != "" {
20 if len(page) != 20 || p.PrevURL != "/-/activity?page=2" || p.NextURL != "" {
21 21 t.Fatalf("page 3 = len %d, %+v", len(page), p)
22 22 }
23 23 if _, p = paginate(events, 99, 50, instanceActivityURL(""), "Activity pages"); p.Page != 3 {
@@ -31,7 +31,7 @@ func TestPaginateClampsToTheFeed(t *testing.T) {
31 31 }
32 32 // A filtered feed keeps its filter in the page links: paging must not
33 33 // silently widen what the reader asked for.
34 if _, p = paginate(events, 1, 50, instanceActivityURL("issue"), "Activity pages"); p.NextURL != "/activity?kind=issue&page=2" {
34 if _, p = paginate(events, 1, 50, instanceActivityURL("issue"), "Activity pages"); p.NextURL != "/-/activity?kind=issue&page=2" {
35 35 t.Fatalf("filtered next URL = %q", p.NextURL)
36 36 }
37 37 // A page size below one is treated as one rather than dividing by zero.
@@ -42,19 +42,19 @@ func TestPaginateClampsToTheFeed(t *testing.T) {
42 42
43 43 func TestPageSection(t *testing.T) {
44 44 cases := map[string]string{
45 "/": "home",
46 "/r/demo": "repos",
47 "/r/demo/issues": "repos",
48 "/activity": "activity",
49 "/repos/new": "repos",
50 "/users": "admin",
51 "/users/keenan": "admin",
52 "/admin": "admin",
53 "/u": "people",
54 "/u/keenan": "people",
55 "/account": "account",
56 "/login": "",
57 "/status": "admin",
45 "/": "home",
46 "/demo": "repos",
47 "/demo/issues": "repos",
48 "/-/activity": "activity",
49 "/-/repos/new": "repos",
50 "/-/users": "admin",
51 "/-/users/keenan": "admin",
52 "/-/admin": "admin",
53 "/-/u": "people",
54 "/-/u/keenan": "people",
55 "/-/account": "account",
56 "/-/login": "",
57 "/-/status": "admin",
58 58 }
59 59 for path, want := range cases {
60 60 if got := pageSection(path); got != want {