Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 9h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/activity_pages_test.go +5−5

@@ -32,7 +32,7 @@ func TestActivityFeedIsPaginatedAcrossItsWholeHistory(t *testing.T) {
32 32 count := func(body string) int { return strings.Count(body, `class="activity-event"`) }
33 33
34 34 // Repository feed: page one is the newest 50 of 55, page two is the rest.
35 code, body := f.get("/r/" + f.repo + "/activity")
35 code, body := f.get("/" + f.repo + "/activity")
36 36 if code != 200 {
37 37 t.Fatalf("activity page = %d", code)
38 38 }
@@ -46,7 +46,7 @@ func TestActivityFeedIsPaginatedAcrossItsWholeHistory(t *testing.T) {
46 46 t.Fatalf("page one has no pager:\n%s", body)
47 47 }
48 48
49 _, body = f.get("/r/" + f.repo + "/activity?page=2")
49 _, body = f.get("/" + f.repo + "/activity?page=2")
50 50 if n := count(body); n != 5 {
51 51 t.Fatalf("page two shows %d events, want 5", n)
52 52 }
@@ -58,17 +58,17 @@ func TestActivityFeedIsPaginatedAcrossItsWholeHistory(t *testing.T) {
58 58 }
59 59
60 60 // The instance feed carries the same history.
61 _, body = f.get("/activity")
61 _, body = f.get("/-/activity")
62 62 if n := count(body); n != 50 {
63 63 t.Fatalf("instance page one shows %d events, want 50", n)
64 64 }
65 _, body = f.get("/activity?page=2")
65 _, body = f.get("/-/activity?page=2")
66 66 if n := count(body); n != 5 || !strings.Contains(body, "issue 00") {
67 67 t.Fatalf("instance page two shows %d events:\n%s", n, body)
68 68 }
69 69
70 70 // A filter travels with the page links, so paging never widens the feed.
71 _, body = f.get("/r/" + f.repo + "/activity?kind=issues&actor=keenan")
71 _, body = f.get("/" + f.repo + "/activity?kind=issues&actor=keenan")
72 72 if !strings.Contains(body, "kind=issue") || !strings.Contains(body, "actor=keenan") || !strings.Contains(body, "page=2") {
73 73 t.Fatalf("filtered pager lost a filter:\n%s", body)
74 74 }