Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 9h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/web/mentions_test.go +5−5

@@ -15,7 +15,7 @@ func TestMentionsBecomeProfileLinks(t *testing.T) {
15 15 s := newSite(t)
16 16 html := string(s.web.renderMarkdown("demo", "hi @alice, take a look"))
17 17
18 if !strings.Contains(html, `href="/u/alice"`) || !strings.Contains(html, ">@alice</a>") {
18 if !strings.Contains(html, `href="/-/u/alice"`) || !strings.Contains(html, ">@alice</a>") {
19 19 t.Fatalf("mention was not linked:\n%s", html)
20 20 }
21 21 }
@@ -38,7 +38,7 @@ func TestMentionLinksSkipWhatIsNotAnAddress(t *testing.T) {
38 38 for _, c := range cases {
39 39 t.Run(c.name, func(t *testing.T) {
40 40 html := string(s.web.renderMarkdown("demo", c.src))
41 if strings.Contains(html, "/u/alice") || strings.Contains(html, "/u/nobody") {
41 if strings.Contains(html, "/-/u/alice") || strings.Contains(html, "/-/u/nobody") {
42 42 t.Fatalf("%s was linked:\n%s", c.name, html)
43 43 }
44 44 })
@@ -68,7 +68,7 @@ func TestDocumentationDoesNotLinkMentions(t *testing.T) {
68 68 s := newSite(t)
69 69 html := string(s.web.renderTreeMarkdown(treeDoc{Repo: "demo"}, "the @alice flag turns it on"))
70 70
71 if strings.Contains(html, "/u/alice") {
71 if strings.Contains(html, "/-/u/alice") {
72 72 t.Fatalf("a README mention became a profile link:\n%s", html)
73 73 }
74 74 }
@@ -83,7 +83,7 @@ func TestMentionAtLineStartAndAfterPunctuation(t *testing.T) {
83 83 "(@alice) please look",
84 84 } {
85 85 html := string(s.web.renderMarkdown("demo", src))
86 if !strings.Contains(html, `href="/u/alice"`) {
86 if !strings.Contains(html, `href="/-/u/alice"`) {
87 87 t.Fatalf("%q was not linked:\n%s", src, html)
88 88 }
89 89 }
@@ -95,7 +95,7 @@ func TestMentionLinkSurvivesTheSanitizer(t *testing.T) {
95 95 t.Parallel()
96 96 s := newSite(t)
97 97 html := string(s.web.renderMarkdown("demo", "@alice"))
98 if !strings.Contains(html, `href="/u/alice"`) {
98 if !strings.Contains(html, `href="/-/u/alice"`) {
99 99 t.Fatalf("the sanitised mention is not a link:\n%s", html)
100 100 }
101 101 }