Sign in

Search issue titles and bodies, change requests and comments. Private repositories you cannot read are not included.

vole
Clone

Read only, no credentials:

https://rodent.software/vole.git

Write over SSH with a registered key:

git clone ssh://git@rodent.software:2222/vole.git

A free and open-source forge that lives in your Git repo.

Serve repositories from the root of the URL space

ed03b3d1fa16ef6b55e2773aaf10e3be13282c3a · Keenan Nemetz · 9h ago · parent d37d301f

Serve repositories from the root of the URL space

A repository is now /<name> and its Git transport /<name>.git, so the URL a
person opens, the URL a clone uses, and the Go module path are the same name.
The forge's own pages moved under /-/ (admin, accounts, the directory, the
feed, sign-in, assets), a prefix no repository name can start with: names are
[a-z0-9...] and cannot begin with "-". That leaves the router with two disjoint
spaces and removes the /r/ and /git/ prefixes, which existed only to keep
repositories away from the forge's own paths.

Routes: repoRoutes lose /r/; global, auth and admin routes gain /-/; assets
move to /-/static/ because a subtree pattern like /static/ cannot coexist with
one-segment-wildcard repo routes — Go's mux reports them as conflicting
neither-more-specific patterns. The catch-all still renders the styled 404.

Transport: githttp.Route parses /<name>.git/<rest> instead of a /git/ prefix,
and forgepaths.go hands such requests to the proxy before the mux, because a
wildcard fills a whole segment and cannot match "<name>.git". LFS stays on the
mux (<name>.git/info/lfs/...), and the Go module discovery probe moves to the
same pre-router so a package path under a public repository is answered even
when its first segments name a page tab.

Names: repo.ValidateName now refuses the four root paths the forge must keep —
static, robots.txt, sitemap.xml, sitemap-pages.xml. Everything else is an
ordinary repository name, including admin, u, and activity.

Docs and the packaged URLs follow the new layout; robots.txt, the sitemaps and
the instance activity feed point at the new paths. No aliases: the old /r/ and
/git/ URLs are gone.

Verified with ./vole workflow check and ./vole workflow run verify.

server/admin_repos_test.go +7−7

@@ -18,7 +18,7 @@ func TestAdminCreatesRepository(t *testing.T) {
18 18 f.addWriter(t)
19 19 sess, cookie := f.browserSession(t, f.ownerID)
20 20
21 resp, body := f.browserGet(t, "/repos/new", cookie)
21 resp, body := f.browserGet(t, "/-/repos/new", cookie)
22 22 if resp.StatusCode != 200 || !strings.Contains(body, "New repository") || !strings.Contains(body, "wilbur") {
23 23 t.Fatalf("new repository page = %d:\n%s", resp.StatusCode, body)
24 24 }
@@ -29,8 +29,8 @@ func TestAdminCreatesRepository(t *testing.T) {
29 29 "owner": {"wilbur"},
30 30 "description": {"second repository"},
31 31 }
32 resp, _ = f.browserPost(t, "/repos", cookie, form)
33 if resp.StatusCode != 303 || resp.Header.Get("Location") != "/r/demo-two/settings" {
32 resp, _ = f.browserPost(t, "/-/repos", cookie, form)
33 if resp.StatusCode != 303 || resp.Header.Get("Location") != "/demo-two/settings" {
34 34 t.Fatalf("create = %d %q", resp.StatusCode, resp.Header.Get("Location"))
35 35 }
36 36 m, err := f.srv.Repos.Open("demo-two")
@@ -66,20 +66,20 @@ func TestAdminCreatesRepository(t *testing.T) {
66 66 }
67 67
68 68 form.Set("csrf", sess.CSRF)
69 if resp, body := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "already exists") {
69 if resp, body := f.browserPost(t, "/-/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "already exists") {
70 70 t.Fatalf("duplicate = %d:\n%s", resp.StatusCode, body)
71 71 }
72 72 form.Set("name", "Bad Name")
73 if resp, _ := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 400 {
73 if resp, _ := f.browserPost(t, "/-/repos", cookie, form); resp.StatusCode != 400 {
74 74 t.Fatalf("invalid name = %d, want 400", resp.StatusCode)
75 75 }
76 76 form.Set("name", "third")
77 77 form.Set("owner", "nobody")
78 if resp, body := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "active account") {
78 if resp, body := f.browserPost(t, "/-/repos", cookie, form); resp.StatusCode != 400 || !strings.Contains(body, "active account") {
79 79 t.Fatalf("unknown owner = %d:\n%s", resp.StatusCode, body)
80 80 }
81 81 form.Del("csrf")
82 if resp, _ := f.browserPost(t, "/repos", cookie, form); resp.StatusCode != 403 {
82 if resp, _ := f.browserPost(t, "/-/repos", cookie, form); resp.StatusCode != 403 {
83 83 t.Fatalf("missing CSRF = %d, want 403", resp.StatusCode)
84 84 }
85 85 }